Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcing the virtual environment to the right spot #1993

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Adjusting the hello-world tutorial with feedback.

@LeStarch LeStarch changed the base branch from master to devel April 28, 2023 00:35
@LeStarch LeStarch requested review from thomas-bc and jwest115 April 28, 2023 17:21
@LeStarch
Copy link
Collaborator Author

@thomas-bc and @jwest115, I did another pass at the hello world tutorial. Here are some minor edits and QoL improvements.

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/Tutorials/HelloWorld/HelloWorld.md Show resolved Hide resolved
Copy link
Collaborator

@jwest115 jwest115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@LeStarch LeStarch merged commit 0701b6a into devel Apr 28, 2023
@LeStarch LeStarch deleted the hello-world-fixes branch May 25, 2023 22:20
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
* Add sourcing the virtual environment to the right spot

* Update HelloWorld.md for minor fixes

* Fixing regressions

* Update Deployments.md with minor fixes

* Update HelloWorld.md to add In: to the instructions

* sp
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
* Add sourcing the virtual environment to the right spot

* Update HelloWorld.md for minor fixes

* Fixing regressions

* Update Deployments.md with minor fixes

* Update HelloWorld.md to add In: to the instructions

* sp
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants