Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing coverage compilations for unit-test files #2013

Merged
merged 2 commits into from
May 18, 2023

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented May 10, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

This fixes #1862. The issue was unit-tests were not being compiled with coverage flags, meaning the profiling was incomplete.

@LeStarch LeStarch requested a review from bocchino May 10, 2023 22:56
@LeStarch
Copy link
Collaborator Author

LeStarch commented May 10, 2023

@bocchino this should work to fix your issue. Some notes:

  1. Make sure to run pip install -r requirements.txt we bumped the gcovr version to 6.0. Verify with: gcovr --version
  2. You will see unit test files included in the report until we merge in: Add flags to include unit test files in coverage fprime-tools#137

I don't think item 2 is blocking.

@LeStarch LeStarch requested review from jwest115 and thomas-bc May 10, 2023 22:58
@LeStarch
Copy link
Collaborator Author

@tiffany1618 if you need to run your FppTest with coverage, base off this branch! It should work well.

@LeStarch
Copy link
Collaborator Author

Went and cleaned out the redundant .gdca removal in the cmake system as that is done in fprime-util. Fixed #2008 as the fix was in the same file.

@tiffany1618
Copy link
Contributor

@LeStarch Thanks! This is working for coverage in FppTest now.

@LeStarch
Copy link
Collaborator Author

Woooooooo!

@LeStarch LeStarch merged commit 0565987 into nasa:devel May 18, 2023
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
* Fix missing coverage compilations for unit-test files

* Cleaning up .gdca removal, fixing nasa#2008
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
* Fix missing coverage compilations for unit-test files

* Cleaning up .gdca removal, fixing #2008
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants