Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fprime cli documentation #2025

Merged
merged 4 commits into from
May 17, 2023

Conversation

SMorettini
Copy link
Contributor

Originating Project/Creator
Affected Component Documentation
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Update the documentation of the fprime-cli.

@SMorettini SMorettini changed the base branch from master to devel May 15, 2023 10:08
@SMorettini
Copy link
Contributor Author

The spell-checking is failing for non-existent, should I add it in the exceptions or changed in the documentation? It comes from running fprime-cli --help

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's outputted by fprime-cli it's probably best to add it to the expected list. Thanks for updating this!

@thomas-bc
Copy link
Collaborator

thomas-bc commented May 16, 2023

Food for thought:
this pattern of displaying in the docs what the output of a --help command is seems questionable to me. For example, the next release of fprime-gds will yet again modify this output, replacing -r with -d (see here). Are we going to have to remember to update this again then? Most likely, we will forget. Should these things be scrubbed? Could we auto-generate them somehow?

@SMorettini
Copy link
Contributor Author

SMorettini commented May 17, 2023

I updated the non-existent to nonexistent to solve the spelling issue. Adding it to the expected list didn't work, I think that line_forbidden.patterns has a higher priority than the expected list.

About

Food for thought: this pattern of displaying in the docs what the output of a --help command is seems questionable to me. For example, the next release of fprime-gds will yet again modify this output, replacing -r with -d (see here). Are we going to have to remember to update this again then? Most likely, we will forget. Should these things be scrubbed? Could we auto-generate them somehow?

I agree, I think that if we can autogenerate it would be very interesting but I'm not an expert in CI setup so I don't know how to do it. I think it can also make sense to remove it from the documentation since the user can find it by itself. If you want me to remove it I can do it directly in this pull request. Let me know what you prefer.

@LeStarch
Copy link
Collaborator

There is reason to keep this around, but I'd argue in a different format. Like how online Linux man-pages are setup. Autogeneration would be awesome, and it should be relegated to API like documentation rather than inside the user guide.

This is a nice stop-gap, so I'll merge.

@LeStarch LeStarch merged commit 0c13ee8 into nasa:devel May 17, 2023
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
* Update help messages of fprime-cli

* Added zmq to admissible words

* Adding non-existent in spelling exception

* Substituting non-existent with nonexistent
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
* Update help messages of fprime-cli

* Added zmq to admissible words

* Adding non-existent in spelling exception

* Substituting non-existent with nonexistent
thomas-bc added a commit that referenced this pull request Aug 4, 2023
@SMorettini SMorettini deleted the Update-fprime-cli-documentation branch February 6, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants