Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake -P argument #2031

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix CMake -P argument #2031

merged 1 commit into from
May 18, 2023

Conversation

pcrosemurgy
Copy link
Contributor

@pcrosemurgy pcrosemurgy commented May 18, 2023 •
edited
Loading

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n) n
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n) n

Change Description

Fixes -P argument syntax. With CMake (version 3.18.4) a space must be provided after -P.
See https://github.com/nasa/fprime/pull/1994/files#r1197366601.

Future Work

I'm surprised this wasn't caught by CI. May be worth checking what version of CMake CI runs with.

@pcrosemurgy pcrosemurgy mentioned this pull request May 18, 2023
Merged
@pcrosemurgy pcrosemurgy marked this pull request as ready for review May 18, 2023 04:59
@LeStarch LeStarch self-requested a review May 18, 2023 16:09
LeStarch
LeStarch approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space seems ok to me!

@LeStarch LeStarch merged commit cf414a7 into nasa:devel May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcrosemurgy @LeStarch