Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fprime-community projects as part of CI checks #2049

Merged
merged 10 commits into from
May 31, 2023

Conversation

thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented May 26, 2023

Originating Project/Creator
Affected Component GitHub Actions
Affected Architectures(s) CI
Related Issue(s) #2000 🎉 🍾

Change Description

Introduces a Reusable Workflow (reusable-builder.yml) that allows to build and run tests on an external F´ project, with the current revision of F´. This allows, for example, to build and run UTs on fprime-community/fprime-workshop-led-blinker as part of a CI check on PRs within F´ core.

Rationale

This is going to help in many ways:

  • more testing, that's always good
  • will prevent our examples/references from breaking
  • improved traceability in changes. If a change is made that breaks an example: first of all we will know (not always obvious), and we can strongly recommend (or better, enforce) that the fprime-community project should be updated.

That could even lead to some sorts of "Migration references" - with our references evolving over time to catch up with the F´ changes - we can diff between releases to show what has changed in how you use F´.

Testing/Review Recommendations

"Let the CI fly!"
- LeStarch

Future Work

  • Introduce workflows for other projects such as HelloWorld, SystemReference when it's ready, and other projects (incoming BaremetalReference? 👀 )
  • Pull out Ref/ and RPI/ out of nasa/fprime ?

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! A few comments/questions

.github/workflows/reusable-builder.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-builder.yml Outdated Show resolved Hide resolved
@thomas-bc
Copy link
Collaborator Author

Enabled verbose with a Debug Run: https://github.com/nasa/fprime/actions/runs/5095135148/jobs/9159854919
I also confirmed that the overlaying of the F´ revision is happening as expected by tweaking with my fprime fork and witnessing that the CI build would fail because of it.

@LeStarch
Copy link
Collaborator

@thomas-bc ready to merge?

@thomas-bc
Copy link
Collaborator Author

@LeStarch ready to merge!

@LeStarch LeStarch merged commit 0aa4770 into nasa:devel May 31, 2023
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
* Added reusable-builder workflow

* Added build-led-blinker

* On push/PR

* not running integration_tests yet

* fix booleans

* add optional target platform

* For once, spelling was nice with me

* misc formatting

* Review recommendations

* fix usage
thomas-bc added a commit that referenced this pull request Aug 4, 2023
* Added reusable-builder workflow

* Added build-led-blinker

* On push/PR

* not running integration_tests yet

* fix booleans

* add optional target platform

* For once, spelling was nice with me

* misc formatting

* Review recommendations

* fix usage
thomas-bc added a commit that referenced this pull request Aug 4, 2023
@thomas-bc thomas-bc deleted the workflow/build-external-repo branch September 29, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants