Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Compiler Documentation Update + Minor CodeQL Alert Resolutions #2098

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

Boehm-Michael
Copy link
Contributor

Originating Project/Creator boehm-Michael
Affected Component N/A
Affected Architectures(s)
Related Issue(s) CodeQL
Has Unit Tests (y/n) N/A
Builds Without Errors (y/n) Y
Unit Tests Pass (y/n) N/A
Documentation Included (y/n) Y

Change Description

Updated cross-compiler documentation and fixed code readability as noted by CodeQL

Rationale

Resolve CodeQL alerts, fix broken cross-compiler documentation

Testing/Review Recommendations

N/A

Future Work

Continue to update for CodeQL alerts.

Fixed PR of #2096

Boehm-Michael and others added 6 commits June 23, 2023 07:48
…t may give bogus warnings. Consider replacing these with //-style comments, with #if 0...#endif, or with more clearly structured multi-line comments." alert.

Fixed all
	- Except external libraries
…d be at the beginning of the declaration." alert.

All resolved.
Correct for most recent version of devel.
U32 context /*!<
Call context value; meaning chosen by user
*/
void from_PktSend_handler(const NATIVE_INT_TYPE portNum, //!< The port number*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the closing */

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few */ ending comments that remain we should clean those up.

Also, I was hoping we could pull all these instructions into a separate package. e.g. docs/Tutorials/CrossCompilationSetup where we talk through installing each peice and the toolchain as a separate pseudo-tutorial that would be linked from exerywhere.

Do you want to refactor that or should I?

Svc/TlmChan/test/ut/Tester.hpp Outdated Show resolved Hide resolved
Ref/TypeDemo/TypeDemo.hpp Outdated Show resolved Hide resolved
Ref/TypeDemo/TypeDemo.hpp Outdated Show resolved Hide resolved
@jwest115
Copy link
Collaborator

jwest115 commented Jul 17, 2023

@LeStarch I split the documentation into different sections:

  • Cross Compilation Setup
  • Compiling for ARM
  • Running on ARM Linux

All of the above have been added to the "CrossCompilationSetup" directory, which can be referenced in other tutorials.

Note: I did remove the original "Cross-Compilation Tutorial", since it has been split into multiple sections. I can add it back if you think we need it.

As for next steps, we may want to go through the other tutorials to make sure things are linked properly.

@jwest115 jwest115 merged commit eabd5a5 into nasa:devel Jul 17, 2023
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
…2098)

* Updates to resolve "Complex multi-line /.../-style comment found. Lint may give bogus warnings. Consider replacing these with //-style comments, with #if 0...#endif, or with more clearly structured multi-line comments." alert.

Fixed all
	- Except external libraries

* Resolve "Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration." alert.

All resolved.

* Updated F Prime Cross Compilation Documentation

Correct for most recent version of devel.

* Spelling Fixes

* Remove URL Pattern

* Added `rancherdesktop` to expect.txt

* cross-compile tutorial re-organization

* add macos.md and add step for running executable

* clean up command to run executable

* change [...] to <...>

---------

Co-authored-by: Justine West <justine.a.west@jpl.nasa.gov>
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants