Fixing undefined behavior in lib CRC #2269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
A lack of casting in libcrc tripped the undefined behavior and address sanitizers when running
update_crc_16
. This occurs when the result is-1
and passed as an index. By forcing a cast tounsigned int
, the index should be guided back into a non-negative range.Future Work
We should search for and possible baseline a flight-quality implementation of CRCs/