-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize PR process for breaking changes #2289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Oct 5, 2023
LeStarch
approved these changes
Oct 5, 2023
LeStarch
pushed a commit
that referenced
this pull request
Dec 20, 2023
… XML to topology dictionary (#2419) Co-authored-by: Jack White <jack.white@redwirespaceeurope.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When building external repositories (with reusable-builder.yml) such as our tutorial suite, CI will first check for the existence of the branch
pr-<PR_NUMBER>
on the external repository. If a branch is found, use it. If not, usedevel
.Rationale
This will allow developers to propose changes (and CI to run on those changes) without needing to merge them into
devel
, which was a source of weirdnesses in the process. Also allows for concurrent PRs to be reviewed, without having to merge one first for the other one to be reviewable.Comments
This is honestly just a proposal. Everything is interconnected and that makes it hard to come up with a really clean solution. This is the best I could do - let me know if you can think of other ideas.
Future work
Consider dropping the
main
branch on the tutorial repos, and only usedevel
like we're doing on core F´ and tools/GDS.