Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in FppTest #2494

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix issues in FppTest #2494

merged 2 commits into from
Jan 24, 2024

Conversation

bocchino
Copy link
Collaborator

This PR fixes some issues in FppTest.

  1. I noticed that the sanitizer was complaining about an array size of zero. I fixed it.
  2. I noticed that a test was assuming a non-empty test string, and it failed in the case where the random test string was empty. I added the constraint that the string must have min length 1.
  3. I cleaned up the logic and added some assertions in the function for generating random strings.
  4. I removed trailing spaces from the files that I touched.

@bocchino bocchino requested a review from LeStarch January 19, 2024 19:50
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question.

FppTest/struct/PrimitiveStructTest.cpp Show resolved Hide resolved
@LeStarch LeStarch merged commit 94c8fec into nasa:devel Jan 24, 2024
34 checks passed
@bocchino bocchino deleted the fix-fpp-test branch January 27, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants