Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add markdown link checker #2651

Merged
merged 20 commits into from
Apr 24, 2024
Merged

feat(ci): add markdown link checker #2651

merged 20 commits into from
Apr 24, 2024

Conversation

SauravMaheshkar
Copy link
Contributor

Related Issue(s) #1840
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

This PR adds a workflow for checking broken links in Markdown files

Rationale

Fixes #1840

@LeStarch
Copy link
Collaborator

Well, without surprise....this yielded many changes necessary.

@thomas-bc
Copy link
Collaborator

I think we may want to use

  - use-quiet-mode: 'yes'

Specify yes to only show errors in output.

https://github.com/gaurav-nelson/github-action-markdown-link-check?tab=readme-ov-file#custom-variables

@SauravMaheshkar
Copy link
Contributor Author

How would you like to proceed with this:

A) incorporate all links fixes in this PR. (maybe even one squash'ed commit)
B) Merge this PR, and make subsequent PRs fixing the links.

Something else?

@thomas-bc
Copy link
Collaborator

I think we're going to want to go with A otherwise it's going to break other PRs and the main branch. We squash PRs as a single commit so no worries about making lots of small commits. I'll give you a hand as soon as I can

@thomas-bc
Copy link
Collaborator

Well, that was cumbersome, but that should do it!

A very few things was so old that I removed it.
Most were tracked down.
A couple in the CMake API I hardcoded, since the relative ../api/ links are dead in Markdown anyways, since api/ is generated a docgen-time

We might take a little while to review everything. Will get back to you once we got back to it.

@SauravMaheshkar
Copy link
Contributor Author

Well, that was cumbersome, but that should do it!

A very few things was so old that I removed it. Most were tracked down. A couple in the CMake API I hardcoded, since the relative ../api/ links are dead in Markdown anyways, since api/ is generated a docgen-time

We might take a little while to review everything. Will get back to you once we got back to it.

Thanks for all the help @thomas-bc

@LeStarch LeStarch self-requested a review April 10, 2024 20:05
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to rework with the rewritten Test API guide.

Ref/docs/sdd.md Outdated Show resolved Hide resolved
Svc/TlmPacketizer/docs/sdd.md Outdated Show resolved Hide resolved
Svc/TlmPacketizer/docs/sdd.md Outdated Show resolved Hide resolved
@thomas-bc
Copy link
Collaborator

@SauravMaheshkar would you be able to make the changes that were requested by LeStarch's review, as well as resolving the merge conflict? All changes from devel in docs/UsersGuide/dev/testAPI/user_guide.md should be taken in

@thomas-bc thomas-bc merged commit 109e4bd into nasa:devel Apr 24, 2024
34 checks passed
@SauravMaheshkar SauravMaheshkar deleted the 1840-ci-markdown-link-checker branch April 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action - Markdown link check
3 participants