Add Fw::ExternalString and revise string implementations

Fw/Cmd/CMakeLists.txt

@@ -12,6 +12,5 @@ set(SOURCE_FILES
   "${CMAKE_CURRENT_LIST_DIR}/CmdArgBuffer.cpp"
   "${CMAKE_CURRENT_LIST_DIR}/CmdPacket.cpp"
   "${CMAKE_CURRENT_LIST_DIR}/Cmd.fpp"
-  "${CMAKE_CURRENT_LIST_DIR}/CmdString.cpp"
 )
 register_fprime_module()

Fw/Cmd/CmdString.hpp

@@ -1,37 +1,59 @@
-#ifndef FW_CMD_STRING_TYPE_HPP
-#define FW_CMD_STRING_TYPE_HPP
+// ======================================================================
+// @file   CmdString.hpp
+// @author F Prime
+// @brief  A string sized for a command argument
+// ======================================================================
+
+#ifndef FW_CMD_STRING_HPP
+#define FW_CMD_STRING_HPP
 
 #include <FpConfig.hpp>
-#include <Fw/Types/StringType.hpp>
-#include <Fw/Cfg/SerIds.hpp>
+
+#include "Fw/Cfg/SerIds.hpp"
+#include "Fw/Types/StringBase.hpp"
 
 namespace Fw {
 
-    class CmdStringArg : public Fw::StringBase {
-        public:
+class CmdStringArg final : public StringBase {
+  public:
+    enum {
+        SERIALIZED_TYPE_ID = FW_TYPEID_CMD_STR,
+        STRING_SIZE = FW_CMD_STRING_MAX_SIZE,
+        SERIALIZED_SIZE = STRING_SIZE + sizeof(FwSizeStoreType)
+    };
 
-            enum {
-                SERIALIZED_TYPE_ID = FW_TYPEID_CMD_STR,
-                SERIALIZED_SIZE = FW_CMD_STRING_MAX_SIZE + sizeof(FwBuffSizeType)
-            };
+    CmdStringArg() : StringBase() { *this = ""; }
 
-            CmdStringArg(const char* src);
-            CmdStringArg(const StringBase& src);
-            CmdStringArg(const CmdStringArg& src);
-            CmdStringArg();
-            CmdStringArg& operator=(const CmdStringArg& other);
-            CmdStringArg& operator=(const StringBase& other);
-            CmdStringArg& operator=(const char* other);
-            ~CmdStringArg();
+    CmdStringArg(const CmdStringArg& src) : StringBase() { *this = src; }
 
-            const char* toChar() const;
-            NATIVE_UINT_TYPE getCapacity() const ; //!< return buffer size
+    CmdStringArg(const StringBase& src) : StringBase() { *this = src; }
 
-        private:
+    CmdStringArg(const char* src) : StringBase() { *this = src; }
 
-            char m_buf[FW_CMD_STRING_MAX_SIZE];
-    };
+    ~CmdStringArg() {}
+
+    CmdStringArg& operator=(const CmdStringArg& src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    CmdStringArg& operator=(const StringBase& src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    CmdStringArg& operator=(const char* src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    const char* toChar() const { return this->m_buf; }
+
+    StringBase::SizeType getCapacity() const { return sizeof this->m_buf; }
 
-}
+  private:
+    char m_buf[CmdStringArg::STRING_SIZE];
+};
+}  // namespace Fw
 
 #endif

Fw/Log/CMakeLists.txt

@@ -12,8 +12,6 @@ set(SOURCE_FILES
   "${CMAKE_CURRENT_LIST_DIR}/LogBuffer.cpp"
   "${CMAKE_CURRENT_LIST_DIR}/LogPacket.cpp"
   "${CMAKE_CURRENT_LIST_DIR}/Log.fpp"
-  "${CMAKE_CURRENT_LIST_DIR}/LogString.cpp"
-  "${CMAKE_CURRENT_LIST_DIR}/TextLogString.cpp"
 
 )
 register_fprime_module()

Fw/Log/LogString.hpp

@@ -1,41 +1,59 @@
-#ifndef FW_LOG_STRING_TYPE_HPP
-#define FW_LOG_STRING_TYPE_HPP
+// ======================================================================
+// @file   LogString.hpp
+// @author F Prime
+// @brief  A string sized for an event log entry
+// ======================================================================
+
+#ifndef FW_LOG_STRING_HPP
+#define FW_LOG_STRING_HPP
 
 #include <FpConfig.hpp>
-#include <Fw/Types/StringType.hpp>
-#include <Fw/Cfg/SerIds.hpp>
+
+#include "Fw/Cfg/SerIds.hpp"
+#include "Fw/Types/StringBase.hpp"
 
 namespace Fw {
 
-    class LogStringArg : public Fw::StringBase {
-        public:
+class LogStringArg final : public StringBase {
+  public:
+    enum {
+        SERIALIZED_TYPE_ID = FW_TYPEID_LOG_STR,
+        STRING_SIZE = FW_LOG_STRING_MAX_SIZE,
+        SERIALIZED_SIZE = STRING_SIZE + sizeof(FwSizeStoreType)
+    };
 
-            enum {
-                SERIALIZED_TYPE_ID = FW_TYPEID_LOG_STR,
-                SERIALIZED_SIZE = FW_LOG_STRING_MAX_SIZE + sizeof(FwBuffSizeType) // size of buffer + storage of two size words
-            };
+    LogStringArg() : StringBase() { *this = ""; }
 
-            LogStringArg();
-            LogStringArg(const LogStringArg& src); //!< LogStringArg string constructor
-            LogStringArg(const StringBase& src); //!< other string constructor
-            LogStringArg(const char* src); //!< char* source constructor
-            LogStringArg& operator=(const LogStringArg& other); //!< assignment operator
-            LogStringArg& operator=(const StringBase& other); //!< other string assignment operator
-            LogStringArg& operator=(const char* other); //!< char* assignment operator
-            ~LogStringArg();
+    LogStringArg(const LogStringArg& src) : StringBase() { *this = src; }
 
-            const char* toChar() const override;
-            NATIVE_UINT_TYPE getCapacity() const override;
+    LogStringArg(const StringBase& src) : StringBase() { *this = src; }
 
-            SerializeStatus serialize(SerializeBufferBase& buffer) const override; //!< serialization function
-            SerializeStatus serialize(SerializeBufferBase& buffer, NATIVE_UINT_TYPE maxLen) const override; //!< serialization function
-            SerializeStatus deserialize(SerializeBufferBase& buffer) override; //!< deserialization function
+    LogStringArg(const char* src) : StringBase() { *this = src; }
 
-        private:
+    ~LogStringArg() {}
 
-            char m_buf[FW_LOG_STRING_MAX_SIZE];
-    };
+    LogStringArg& operator=(const LogStringArg& src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    LogStringArg& operator=(const StringBase& src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    LogStringArg& operator=(const char* src) {
+        (void)StringBase::operator=(src);
+        return *this;
+    }
+
+    const char* toChar() const { return this->m_buf; }
+
+    StringBase::SizeType getCapacity() const { return sizeof this->m_buf; }
 
-}
+  private:
+    char m_buf[LogStringArg::STRING_SIZE];
+};
+}  // namespace Fw
 
 #endif