Fix string records for data products #2697
Conversation
TimeBaseStoreType is not the same as TimeBase
Cast to the TimeBaseStore type with a known size
Remove unnecessary const casting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fw/Prm/PrmString.hpp
Outdated
|
|
||
| const char* toChar() const; | ||
| NATIVE_UINT_TYPE getCapacity() const; | ||
| ParamString(const StringBase& src) : StringBase() { *this = src; } |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
Fw/Prm/PrmString.hpp
Outdated
|
|
||
| private: | ||
| ParamString(const char* src) : StringBase() { *this = src; } |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
Fw/Test/String.hpp
Outdated
|
|
||
| const char* toChar() const; //!< gets char buffer | ||
| NATIVE_UINT_TYPE getCapacity() const ; //!< return buffer size | ||
| String(const StringBase& src) : StringBase() { *this = src; } |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
Fw/Test/String.hpp
Outdated
|
|
||
| private: | ||
| String(const char* src) : StringBase() { *this = src; } |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| return static_cast<SizeType>(sizeof(FwSizeStoreType)) + this->length(); | ||
| } | ||
|
|
||
| StringBase::SizeType StringBase::serializedTruncatedSize(FwSizeType maxLength) const { |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| return static_cast<SizeType>(sizeof(FwSizeStoreType)) + this->length(); | ||
| } | ||
|
|
||
| StringBase::SizeType StringBase::serializedTruncatedSize(FwSizeType maxLength) const { |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| @@ -117,6 +117,14 @@ | |||
| return static_cast<SizeType>(StringUtils::string_length(this->toChar(), this->getCapacity())); | |||
| } | |||
|
|
|||
| StringBase::SizeType StringBase::serializedSize() const { | |||
Check notice
Code scanning / CodeQL
Use of basic integral type Note
This PR is a companion to nasa/fpp#408. It incorporates the fix for nasa/fpp#392.
Note: Review and merge #2679 first.