Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Svc.Version component #2747
Add Svc.Version component #2747
Changes from 42 commits
2a5dba3
2e67154
27a58bc
2156618
25ede54
8d30c55
3638982
6160ed2
d1c48ca
5d50140
9b1cd59
68860c9
77c7b49
3b177af
06df65d
2e4b8e7
6229411
7fcff5f
b2eac8f
4e78ca5
d420c18
3d84138
8174258
3a5a366
ed36afb
4176008
8252982
364fc26
ccf88a9
afabdbd
d8effea
83f6f76
acc3367
0528ee4
f80da30
a0c6bed
a8c506c
ab83a41
0e61c22
d43dc24
0ad1828
dd5af24
f8f0f16
bb65216
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/should this be moved inside configureTopology() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be good to add a CMakeLists.txt under
Svc/Ports/
so that we can only includehere, and future ports can easily be added under the Svc/Ports module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this pointed to VersionPorts or are you saying in general?