Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Channel Interface for Telemetry #2757

Merged
merged 13 commits into from
Jun 7, 2024
Merged

Conversation

menaman123
Copy link
Contributor

#2585
No
No

Change Description

Added ChannelInterface.fppi and included the telemetry within it.

Rationale

Part of #2578.

Testing/Review Recommendations

Future Work

Work on other interfaces

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing on devel branch: https://github.com/nasa/fprime/actions/runs/9357605666/job/25757702996
An oversight on our end.

Would you please add CommandInterface.fppi ChannelInterface.fppi and EventInterface.fppi to

@thomas-bc
Copy link
Collaborator

thomas-bc commented Jun 4, 2024

@LeStarch we probably should extend triggers on https://github.com/nasa/fprime/blob/devel/.github/workflows/cmake-test.yml. The tests are pretty quick so I would be in favor of making it run on every PR

@thomas-bc thomas-bc linked an issue Jun 4, 2024 that may be closed by this pull request
sync input port SpiReadWrite: Drv.SpiReadWrite

sync input port SpiReadWrite: Drv.SpiReadWrite
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from a different commit that i did not want to be added to this PR

@menaman123
Copy link
Contributor Author

@thomas-bc do you happen to know why the format keeps failing?

@LeStarch
Copy link
Collaborator

LeStarch commented Jun 7, 2024

@menaman123 format is failing because you have spaces after the commas in that modified python file.

@thomas-bc yes, we can run cmake on every commit. It is faster now.

@menaman123
Copy link
Contributor Author

@LeStarch I think i fixed the spaces. I hope it doesnt fail again

@LeStarch
Copy link
Collaborator

LeStarch commented Jun 7, 2024

I went ahead and touched up the formatting and reverted the file you did not want. Hopefully it will build cleanly now.

@LeStarch LeStarch merged commit b0e6023 into nasa:devel Jun 7, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Telemetry/Channel Interface
3 participants