-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Channel Interface for Telemetry #2757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failing on devel
branch: https://github.com/nasa/fprime/actions/runs/9357605666/job/25757702996
An oversight on our end.
Would you please add CommandInterface.fppi
ChannelInterface.fppi
and EventInterface.fppi
to
fprime/cmake/test/src/test_unittests.py
Line 133 in 7d10786
expected_ac = ["SignalGen.fpp", "Commands.fppi", "Events.fppi", "Telemetry.fppi"] fprime/cmake/test/src/test_ref_shared.py
Line 112 in 7d10786
expected_ac = ["SignalGen.fpp", "Commands.fppi", "Events.fppi", "Telemetry.fppi"]
@LeStarch we probably should extend triggers on https://github.com/nasa/fprime/blob/devel/.github/workflows/cmake-test.yml. The tests are pretty quick so I would be in favor of making it run on every PR |
sync input port SpiReadWrite: Drv.SpiReadWrite | ||
|
||
sync input port SpiReadWrite: Drv.SpiReadWrite | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from a different commit that i did not want to be added to this PR
@thomas-bc do you happen to know why the format keeps failing? |
@menaman123 format is failing because you have spaces @thomas-bc yes, we can run cmake on every commit. It is faster now. |
@LeStarch I think i fixed the spaces. I hope it doesnt fail again |
I went ahead and touched up the formatting and reverted the file you did not want. Hopefully it will build cleanly now. |
Change Description
Added ChannelInterface.fppi and included the telemetry within it.
Rationale
Part of #2578.
Testing/Review Recommendations
Future Work
Work on other interfaces