Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Os::Queue into CMake selection #2895

Merged
merged 25 commits into from
Sep 30, 2024

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Sep 24, 2024

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

This refactors Os::Queue to follow the new OSAL interface as documented in #2725. As part of this effort the PriorityQueue implementation as included. An initial pass at condition variables was implemented as these were needed for the PriorityQueue implementation.

@LeStarch LeStarch changed the title Issue #2725 OSAL ueue Issue #2725 OSAL Queue Sep 24, 2024
Os/Condition.hpp Fixed Show fixed Hide fixed
Os/Generic/PriorityQueue.cpp Fixed Show fixed Hide fixed
Os/Generic/PriorityQueue.hpp Dismissed Show dismissed Hide dismissed
Os/Generic/PriorityQueue.hpp Dismissed Show dismissed Hide dismissed
Os/Mutex.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/condition/ConditionRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/condition/ConditionRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/condition/ConditionRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/condition/ConditionRules.hpp Fixed Show fixed Hide fixed
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review comments

Os/Queue.hpp Show resolved Hide resolved
Os/Queue.hpp Outdated Show resolved Hide resolved
Os/Queue.hpp Outdated Show resolved Hide resolved
Os/Generic/PriorityQueue.cpp Outdated Show resolved Hide resolved
Os/Generic/PriorityQueue.cpp Show resolved Hide resolved
Os/Generic/PriorityQueue.cpp Show resolved Hide resolved
Os/Generic/PriorityQueue.cpp Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator Author

Add Os::Model for Queue status.

Os/Mutex.hpp Dismissed Show dismissed Hide dismissed
Os/Mutex.hpp Dismissed Show dismissed Hide dismissed
Os/Queue.hpp Dismissed Show dismissed Hide dismissed
Os/Stub/test/ConditionVariable.hpp Fixed Show fixed Hide fixed
Os/Stub/test/ConditionVariable.hpp Dismissed Show dismissed Hide dismissed
Os/Stub/test/ConditionVariable.hpp Dismissed Show dismissed Hide dismissed
Os/Stub/test/ut/StubTests.cpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/queue/QueueRules.hpp Fixed Show fixed Hide fixed
Os/Condition.cpp Dismissed Show dismissed Hide dismissed
Os/Queue.cpp Dismissed Show dismissed Hide dismissed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Os/Generic/Types/MaxHeap.cpp Fixed Show fixed Hide fixed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@LeStarch LeStarch added the Update Instructions Needed Need to add instructions in the release notes for updates. label Sep 27, 2024
@LeStarch LeStarch force-pushed the issue-2725-osal-queue branch from 576d038 to d8b5ba0 Compare September 27, 2024 18:34
Fw/Comp/QueuedComponentBase.cpp Dismissed Show dismissed Hide dismissed
Os/Condition.cpp Dismissed Show dismissed Hide dismissed
Os/Condition.hpp Dismissed Show dismissed Hide dismissed
Os/Generic/PriorityQueue.cpp Dismissed Show dismissed Hide dismissed
Os/Generic/PriorityQueue.cpp Dismissed Show dismissed Hide dismissed
Os/Queue.cpp Dismissed Show dismissed Hide dismissed
Os/Queue.cpp Dismissed Show dismissed Hide dismissed
Os/Queue.hpp Dismissed Show dismissed Hide dismissed
Os/Stub/Task.cpp Dismissed Show dismissed Hide dismissed
Os/Stub/Task.cpp Dismissed Show dismissed Hide dismissed
@LeStarch LeStarch force-pushed the issue-2725-osal-queue branch from 6c0ac83 to c4abc94 Compare September 30, 2024 17:09
Os/Generic/Types/MaxHeap.cpp Dismissed Show dismissed Hide dismissed
@thomas-bc thomas-bc changed the title Issue #2725 OSAL Queue Refactor Os::Queue into CMake selection Sep 30, 2024
@LeStarch LeStarch merged commit d034786 into nasa:devel Sep 30, 2024
47 of 48 checks passed
thomas-bc added a commit to fprime-community/fprime-tutorial-math-component that referenced this pull request Sep 30, 2024
Co-authored-by: Michael D Starch <Michael.D.Starch@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Instructions Needed Need to add instructions in the release notes for updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants