Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed F' C header files to be C++ compliant. #2936

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

bdshenker
Copy link
Collaborator

Related Issue(s) None
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Make affected .h files C++ compliant by adding the following construct:

#include __cplusplus
extern "C" {
#endif

// ... C-definitions

#include __cplusplus
}
#endif

Rationale

This update allows inclusion of the affected header files from C++ files.

Testing/Review Recommendations

Testing was done by running CI.
In addition these files were temporarily included from one of the C++ source files (.cpp) and FPrime was successfully rebuilt.

Future Work

None

@bdshenker
Copy link
Collaborator Author

Not sure how .h files header update caused CI to fail. Need to investigate.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LeStarch LeStarch closed this Oct 10, 2024
@LeStarch LeStarch reopened this Oct 10, 2024
@LeStarch
Copy link
Collaborator

Only RPI is failing, so will merge!

@LeStarch LeStarch merged commit dc6a29c into nasa:devel Oct 10, 2024
49 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants