Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string specifiers for queue and task names #3146

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

celskeggs
Copy link
Contributor

Related Issue(s) n/a
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Replace format string specifier %d with %PRI_FwSizeType where it is used for FwSizeType values. This is needed in two cases gated behind FW_OBJECT_NAMES == 0.

Rationale

The %d specifier for FwSizeType values does not work on platforms where FwSizeType is 64 bits. The replacement works correctly on all platforms. It appears that this was missed due to a lack of validation of FW_OBJECT_NAMES == 0 code, or perhaps a lack of -Werror in the native toolchain.

Testing/Review Recommendations

N/A

Future Work

Implementing #3100 might help catch these kinds of bugs sooner.

@LeStarch LeStarch merged commit a16f260 into nasa:devel Jan 21, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants