Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for better readability added f-string for formatting #779

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

AliMuhammadOfficial
Copy link
Contributor

@AliMuhammadOfficial AliMuhammadOfficial commented Jun 25, 2021

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

added f-string for better readability and code standard.

Rationale

A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

Copy link
Contributor

@Joshua-Anderson Joshua-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping switch us over to using f-strings!

These were added to python 3.6 now that we've established our python minimum version at 3.6 we can migrate over to using them. To my knowledge this is the current python best practice for string formatting and I think it's a nice improvement overall.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me. Merging once CI passes.

@LeStarch
Copy link
Collaborator

I corrected the one line that failed the formatting check. It should pass the formatter now.

@LeStarch LeStarch merged commit e2898cd into nasa:devel Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants