Switch CI to run in VM instead of docker container #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshua-Anderson
force-pushed
the
switch-ci-from-docker
branch
from
57cbd27 to
845415b
Compare
Joshua-Anderson
changed the title
LeStarch
reviewed
Aug 18, 2021
Joshua-Anderson
force-pushed
the
switch-ci-from-docker
branch
2 times, most recently
from
3892554 to
128c67a
Compare
Joshua-Anderson
force-pushed
the
switch-ci-from-docker
branch
from
128c67a to
cd87b6b
Compare
|
@LeStarch Ready for a re-review! |
LeStarch
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Instead of running CI steps inside of a docker container, run in the github provided 18.04 VM.
Rationale
CI was the primary user of the fprime docker container and releasing new docker containers was a maintenance burden.
Since we were testing in ubuntu 18.04 anyway the docker container wasn't providing value.
Future Work
This will enable the ability for us to more easily test against ubuntu 20.04 in the future without needing to release more docker containers.