Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimewidget): fix broken onBlur event handling #64

Merged

Conversation

benforshey
Copy link
Contributor

@rsjf (or our onBlur function) did not correctly handle the onBlur event--the input's value would not save to form state. onBlur now calls @rsjf's native onChange event.

fix #53470

@rsjf (or our `onBlur` function) did not correctly handle the onBlur event--the input's value would
not save to form state. `onBlur` now calls @rsjf's native `onChange` event.

fix #53470
@benforshey benforshey self-assigned this Sep 30, 2024
@benforshey benforshey added the bug Something isn't working label Sep 30, 2024
@benforshey
Copy link
Contributor Author

To test this PR, please run mEditor locally and choose any model that uses "format": "date-time" as a property (Alerts do). Using Alerts as an example, verify that (in a new document) you can:

  • set a Start with the date picker (click the date you want)
  • set an Expiration by either copying/pasting the Start or manually entering the datetime.
  • save the document

Copy link
Contributor

@KrupaRami KrupaRami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working as expected...approving!

@benforshey benforshey merged commit f36002a into main Oct 1, 2024
5 checks passed
@benforshey benforshey deleted the bugfix/datepicker-should-accept-keyboard-and-mouse-input branch October 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants