Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/meditor 858 bulk UI #65

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

KrupaRami
Copy link
Contributor

This PR has following changes from the document list (model search) page:
Add one or more fields to be updated in the selected documents
List (or search for) fields in a model. These fields can have multiple levels, for example: "Project.Name"
Allow user to input a value to change the field to
Show success/failure responses

To Test:
visit localhost/meditor, navigate to model page and select documents to change the fields. there is bulk select button on top which opens bulk update model. edit fields and submit your changes. it should close the model and show success toast after submission with number of documents updated. check those documents to make sure field has been updated.

@KrupaRami KrupaRami self-assigned this Oct 21, 2024
@benforshey
Copy link
Contributor

Hey, sorry that it's taken so long for me to review this. It's an awesome feature, and the progress you've made on it is amazing! I was able to use the replace operation to edit schema fields, and it worked great. After using it for a little while and trying other operations, I've come to realize that Bulk Update is an absolutely massive feature that probably needs to be broken down into a story per patch operation (replace, delete, add, move, copy), since each of those have different use cases and probably need to be handled differently. I'll get into that more below.

As I was working through the code and UI, I noticed a few things that we can discuss:

  • There are a number of console logs that you probably want to remove, and there are a few places where commented-out code is still in the codebase ("test" is a option in the operations select element, too).
  • The patch operation doesn't always make sense with the form UI. For a delete operation, should we still show the path value? Or for a move operation, what should the path value be? What should move to—are we letting them move the value of a schema path to another schema path? If so what should the UI show and how to we help the user not make mistakes / validate against that?
  • Enumerated values from the schema aren't filled out by the macros—they just show "placeholder".
  • The "title" of a document doesn't show up as an editable field. Is that intentional?

I basically have a million more questions about how things should work for this UI. Like I was saying above, I think we probably need to have a discussion about it during the team meeting so we can figure this out and break this down into more stories. Either way, thanks for your work on this—you trail-blazed a path into this whole idea, and the result is impressive!

@KrupaRami
Copy link
Contributor Author

KrupaRami commented Nov 22, 2024

Thanks for reviewing this Ben...Yes I agree, it is a big feature and should broken down into stories per patch operation. I will remove console logs and commented out code which are not required. For the patch operation doesn't always make sense with the form UI I think we should definitely discuss in detail with the team also for The "title" of a document doesn't show up as an editable field. I think that was the intention.
Sounds good to me too we can discuss this in detail in weekly meeting to get teams opinion on this and how do we want to address these. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants