Meditor 910 history reporting incorrectly #66
Conversation
…y and undertanding.
Fix modifiedOn date and improve history details layout
|
Was confused for a second before realizing this is merging from a fork. For anyone else reviewing, here's what I did to use my existing mEditor folder: git remote add aritrivi https://github.com/aritrivi/gesdisc-meditor.git Just make sure to switch back to your origin branch when you're done |
packages/app/documents/service.ts
Outdated
| @@ -95,11 +95,12 @@ export async function createDocument( | |||
| } | |||
|
|
|||
| //* This logic (and associated TODO) is ported from Meditor.js, saveDocument. Minimal modifications were made. | |||
| const rootState = { source: INIT_STATE, target: initialState } | |||
| const modDate = new Date().toISOString() | |||
There was a problem hiding this comment.
Small nit, took me a bit to figure out what modDate was, may be better spelled out, like modifiedOn
There was a problem hiding this comment.
The history panel looks good, Tony! The toLocaleString call is a nice touch.
It looks like Prettier didn't run on these files, which means that the next time someone makes a change and Prettier does run, it'll add your files to their PR for just formatting changes. You can address that by checking which files aren't formatted correctly:
- From
packages/appin your terminal, runnpx prettier -l .This gives you the list of files that don't match our Prettier config. - For each file, feed those files into Prettier with
npx prettier -w <your-file.extension>or just YOLO it once withnpx prettier -w .(this is actually pretty safe since you can just discard changes if any files change that are unrelated to your PR).
Ran Prettier to clean up code. Changed variable name.
|
All PR comments addressed. |
Fix null modifiedOn date for initial document state. Improve history detail layout in the history panel for readability. History issues are still a potential problem when users "edit"/"save"/"submit for review" from a browser window that is not refreshed and current with any new status changes.