Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1756 - Use trusted publisher to publish to PyPi #84

Merged
merged 4 commits into from
May 3, 2024

Conversation

indiejames
Copy link
Contributor

Jira Issue ID

HARMONY-1756

Description

Changes GitHub publish action to use trusted publisher token instead of password stored in GitHub secret.

Local Test Steps

  1. Click on the 'Releases' link in the main page of this GitHub repo
  2. Click on 'Draft release' button.
  3. Create a dummy tag
  4. Choose this branch instead of 'main'
  5. Fill in title and description with whatever
  6. Choose "pre-production release" checkbox
  7. Click on 'Publish release'
  8. Check to the 'Actions' tab on the page and make sure the publish action succeeds
  9. Go to pypi.org and search for harmony-service-lib
  10. Check on the releases and verify that your release is there
  11. Delete your test release

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@indiejames indiejames merged commit 0908309 into main May 3, 2024
11 checks passed
@indiejames indiejames deleted the harmony-1756 branch May 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants