-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.7.1 #355
Release 1.7.1 #355
Conversation
…th amd64 and arm64 architectures;
* [#216] First attempt at build workflow; * [#216] Removed specific branches from build workflow; * [#216] Removed sudo and added make prep; * [#216] Added missing docker dependency; * [#216] Break config and fsw into different runs in build.yml; * [#216] Avoid docker in docker and run build-fsw; * [#216] Attempt to get submodules recursively; * [#216] Added sim job to build workflow; * [#216] Attempt to use checkout@v4;
…olved issue with running minimal-config;
…ect if building unit tests;
…ubmodule update.
… comment out invalid tests as functionality disabled in NOS3;
Confirmed both via shared folders and cloned direct in the provisioned VM:
Wait and confirm we get into ADCS mode 2 (sun pointed) and resolve correctly after a minute or two.
Confirm test passes and still sun pointed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through and looks good! I tested my large testing script on this version (dev branch), with updates to include some thruster commands and for general compatibility, and it ran through with no issues, which verifies that most or all apps are at least producing commands and telemetry stably over the course of hours. Also confirms successful CFDP, RTS Loads, DS captures with a custom table, rotation, NOOPs, TLM requests, RTS runs, among other actions still work.
Edit: Only oddity noticed is the issue Zach notes below
When make real-clean and re-making things work fine. However If I make stop and make launch back to back. Cosmos doesn't seem to launch its Nos3 Launcher after clicking ok. Can others confirm. I know kevin mentioned he noticed this |
I saw this same behavior yesterday when @msuder demo'ed some stuff to me. @msuder was probably using the latest dev branch. I think he fixed it by re-building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving seems to work as long as we rebuild after launching. I can try and look into that issue too, it may not be obvious why cosmos doesn't pop up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. re-created the COSMOS launching issue, which has been filed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested pull request code changes. They all look good to me.
No description provided.