Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.1 #355

Merged
merged 39 commits into from
Aug 31, 2024
Merged

Release 1.7.1 #355

merged 39 commits into from
Aug 31, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Aug 24, 2024

No description provided.

msuder and others added 30 commits May 15, 2024 12:16
* [#216] First attempt at build workflow;

* [#216] Removed specific branches from build workflow;

* [#216] Removed sudo and added make prep;

* [#216] Added missing docker dependency;

* [#216] Break config and fsw into different runs in build.yml;

* [#216] Avoid docker in docker and run build-fsw;

* [#216] Attempt to get submodules recursively;

* [#216] Added sim job to build workflow;

* [#216] Attempt to use checkout@v4;
[#231]  AMD64 and ARM64 container support
[#315] Created RTS3 (safe mode) and edited RTS1 run safe mode;
[#285] Attempted to implemented suggestions from sdunlap-afit
… comment out invalid tests as functionality disabled in NOS3;
@jlucas9
Copy link
Contributor Author

jlucas9 commented Aug 24, 2024

Confirmed both via shared folders and cloned direct in the provisioned VM:

git clone https://github.com/nasa/nos3.git
git checkout dev
git submodule update --init --recurisve
make real-clean
make prep
make
make launch

Wait and confirm we get into ADCS mode 2 (sun pointed) and resolve correctly after a minute or two.
In the COSMOS test runner:

  • Test Suite: Mission_Test
  • Test Group: LPT
  • START (at test group level)

Confirm test passes and still sun pointed.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through and looks good! I tested my large testing script on this version (dev branch), with updates to include some thruster commands and for general compatibility, and it ran through with no issues, which verifies that most or all apps are at least producing commands and telemetry stably over the course of hours. Also confirms successful CFDP, RTS Loads, DS captures with a custom table, rotation, NOOPs, TLM requests, RTS runs, among other actions still work.

Edit: Only oddity noticed is the issue Zach notes below

@zlynch2
Copy link

zlynch2 commented Aug 29, 2024

When make real-clean and re-making things work fine. However If I make stop and make launch back to back. Cosmos doesn't seem to launch its Nos3 Launcher after clicking ok. Can others confirm. I know kevin mentioned he noticed this

@szemerick
Copy link

When make real-clean and re-making things work fine. However If I make stop and make launch back to back. Cosmos doesn't seem to launch its Nos3 Launcher after clicking ok. Can others confirm. I know kevin mentioned he noticed this

I saw this same behavior yesterday when @msuder demo'ed some stuff to me. @msuder was probably using the latest dev branch. I think he fixed it by re-building.

@jlucas9 jlucas9 mentioned this pull request Aug 30, 2024
Copy link

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving seems to work as long as we rebuild after launching. I can try and look into that issue too, it may not be obvious why cosmos doesn't pop up.

Copy link

@szemerick szemerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. re-created the COSMOS launching issue, which has been filed.

Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested pull request code changes. They all look good to me.

@jlucas9 jlucas9 merged commit 4d653f2 into main Aug 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants