Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal packages do not include repo information #148

Closed
ivanperez-keera opened this issue May 23, 2024 · 6 comments
Closed

Cabal packages do not include repo information #148

ivanperez-keera opened this issue May 23, 2024 · 6 comments
Assignees
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Milestone

Comments

@ivanperez-keera
Copy link
Member

ivanperez-keera commented May 23, 2024

Description

The cabal packages do not contain pointers to the repo using the specific entry for this in Cabal, neither for the source, nor to file bug reports. Although such information is not strictly speaking necessary, it helps direct users without having to "jump around" to find out where they need to go.

Type

  • Bug: Cabal files are missing useful information.

Additional context

None.

Requester

  • Ivan Perez

Method to check presence of bug

The following script checks whether cabal files contain bug-reports or repo information:

$ grep -Lre '\(bug-reports\|source-repository\)' --include='*.cabal' ogma**/
ogma-cli/ogma-cli.cabal
ogma-core/ogma-core.cabal
ogma-extra/ogma-extra.cabal
ogma-language-c/ogma-language-c.cabal
ogma-language-cocospec/ogma-language-cocospec.cabal
ogma-language-copilot/ogma-language-copilot.cabal
ogma-language-jsonspec/ogma-language-jsonspec.cabal
ogma-language-smv/ogma-language-smv.cabal
ogma-spec/ogma-spec.cabal

The output should be empty, meaning that all files contain such strings.

Expected result

Running the above grep command prints nothing, indicating that no cabal page is missing bug report or repo source information.

Desired result

Running the above grep command prints nothing, indicating that no cabal page is missing bug report or repo source information.

Proposed solution

Add bug-reports and source-repository entries to all cabal files.

Further notes

None.

@ivanperez-keera ivanperez-keera added CR:Status:Initiated Admin only: Change request that has been initiated CR:Type:Bug Admin only: Change request pertaining to error detected labels Sep 22, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Confirmed that the issue exists.

@ivanperez-keera ivanperez-keera added CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager and removed CR:Status:Initiated Admin only: Change request that has been initiated labels Nov 23, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera ivanperez-keera added CR:Status:Accepted Admin only: Change request accepted by technical lead and removed CR:Status:Confirmed Admin only: Change request that has been acknowledged by the change manager labels Nov 23, 2024
@ivanperez-keera
Copy link
Member Author

Technical Lead: Issue scheduled for fixing in Ogma 1.6.0.

Fix assigned to: @ivanperez-keera .

@ivanperez-keera ivanperez-keera added CR:Status:Scheduled Admin only: Change requested scheduled and removed CR:Status:Accepted Admin only: Change request accepted by technical lead labels Nov 23, 2024
@ivanperez-keera ivanperez-keera added this to the 1.6.0 milestone Nov 23, 2024
@ivanperez-keera ivanperez-keera self-assigned this Nov 23, 2024
@ivanperez-keera ivanperez-keera added CR:Status:Implementation Admin only: Change request that is currently being implemented and removed CR:Status:Scheduled Admin only: Change requested scheduled labels Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…sa#148.

The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…Refs nasa#148.

The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…efs nasa#148.

The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…Refs nasa#148.

The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…asa#148.

The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the specific entry
for this in Cabal, neither for the source, nor to file bug reports. Although
such information is not strictly speaking necessary, it helps direct users
without having to "jump around" to find out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…sa#148.

The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…Refs nasa#148.

The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…efs nasa#148.

The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…Refs nasa#148.

The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
…asa#148.

The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
The cabal packages do not contain pointers to the repo using the
specific entry for this in Cabal, neither for the source, nor to file
bug reports. Although such information is not, strictly speaking,
necessary, it helps direct users without having to "jump around" to find
out where they need to go.

This commit adds both the bug-reports link and the source repository
information to the cabal package.
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
ivanperez-keera added a commit to ivanperez-keera/ogma that referenced this issue Dec 24, 2024
@ivanperez-keera
Copy link
Member Author

Implementor: Solution implemented, review requested.

@ivanperez-keera ivanperez-keera added CR:Status:Verification Admin only: Change request that is currently being verified and removed CR:Status:Implementation Admin only: Change request that is currently being implemented labels Dec 24, 2024
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
    • The code proposed compiles and passes all tests. Details:
    • The solution proposed produces the expected result. Details:
      The following dockerfile checks that there are no files that do not contain a bug-reports field, or source-repository section, after which it prints the message success:
      FROM ubuntu:focal
      
      RUN apt-get update
      
      RUN apt-get install --yes git
      
      SHELL ["/bin/bash", "-c"]
      CMD git clone $REPO \
          && cd $NAME \
          && git checkout $COMMIT \
          && ! grep -Lre 'bug-reports' --include='*.cabal' ogma**/ \
          && ! grep -Lre 'source-repository' --include='*.cabal' ogma**/ \
          && echo "Success"
      Command (substitute variables based on new path after merge):
      $ docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e "PAT=ogma"  -e "COMMIT=0edf304ad690c2f60fdc6309409dfa5c8f19fd79" -it ogma-verify-148
      
  • Implementation is documented. Details:
    No updates needed.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No updates needed.
  • Required version bumps are evaluated. Details:
    No bump needed; change does not affect API or behavior.

@ivanperez-keera
Copy link
Member Author

Change Manager: Implementation ready to be merged.

@ivanperez-keera ivanperez-keera added CR:Status:Closed Admin only: Change request that has been completed and removed CR:Status:Verification Admin only: Change request that is currently being verified labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR:Status:Closed Admin only: Change request that has been completed CR:Type:Bug Admin only: Change request pertaining to error detected
Projects
None yet
Development

No branches or pull requests

1 participant