Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code cleanup] Remove legacy about dialog #4038

Closed
akhenry opened this issue Jul 19, 2021 · 5 comments · Fixed by #4368
Closed

[Code cleanup] Remove legacy about dialog #4038

akhenry opened this issue Jul 19, 2021 · 5 comments · Fixed by #4368
Labels
type:enhancement
Milestone
Target: 1.8.3

Comments

@akhenry
Copy link
Contributor

akhenry commented Jul 19, 2021

Any code associated with the legacy Open MCT "about" dialog bundle should be removed as it's no longer in use.
@akhenry
Copy link
Contributor Author

akhenry commented Jul 19, 2021

Assigned to @khalidadil

@depperm
Copy link
Contributor

depperm commented Oct 23, 2021

willing to do this

@depperm depperm mentioned this issue Oct 25, 2021
Merged
8 tasks
@jvigliotta
Copy link
Contributor

Testing

  • click the Open MCT logo in the top right
  • verify about dialog is working as expected
  • no errors in regular Open MCT use

jvigliotta added a commit that referenced this issue Dec 6, 2021
@depperm @jvigliotta
[Code cleanup] Remove legacy about dialog #4038 (#4368)
63fabe5 
* WIP plan icon

* MCT 4038

* removed other changes

* added remvoed line

* Update _constants.scss

Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
@charlesh88
Copy link
Contributor

Verified fixed Testathon 12-13-21.

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

[Code cleanup] Remove legacy about dialog #4038 depperm/openmct
6 participants
@charlesh88 @nikhilmandlik @akhenry @depperm @jvigliotta @unlikelyzero