Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only zoom and pan should pause plot, not click #4138

Closed
2 of 5 tasks
davetsay opened this issue Aug 20, 2021 · 6 comments · Fixed by #4256
Closed
2 of 5 tasks

only zoom and pan should pause plot, not click #4138

davetsay opened this issue Aug 20, 2021 · 6 comments · Fixed by #4256
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug

Comments

@davetsay
Copy link
Contributor

Summary

Expected vs Current Behavior

Clicking on a plot should not pause the plot. Plot should only pause on zoom or pan, or explicit pause.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Navigate to a plot
  2. Click on the plot

Environment

  • Open MCT Version: 1.7.6
  • Deployment Type:
  • OS:
  • Browser:

Additional Information
@davetsay davetsay added type:bug bug:regression It used to work. Now it doesn't :( labels Aug 20, 2021
@michaelrogers
Copy link
Contributor

michaelrogers commented Sep 23, 2021 •
edited
Loading

I'd like to claim this issue to work on. I am claiming it verbally since I cannot self assign the issue at preset.

@scottbell
Copy link
Contributor

scottbell commented Sep 24, 2021 •
edited
Loading

@michaelrogers Just saw your comment! sorry about that. I created a branch already FWIW called mct4138:
https://github.com/nasa/openmct/tree/mct4138
The issue appears to be the startMarquee function in MctPlot.vue:
https://github.com/nasa/openmct/blob/1.7.8/src/plugins/plot/MctPlot.vue#L738

The marquee is used for zoom in on the plot, so we'll need to distinguish between a real zoom, and the user merely clicking on the plot. Most methods that I found involve some combination of keeping state of the mouseMove event, and having mouseUp and mouseDown read that state.

@michaelrogers
Copy link
Contributor

michaelrogers commented Sep 24, 2021 •
edited
Loading

No problem @scottbell. The approach I took was to check the plotHistory length after endMarquee was invoked. The potential downside of this approach is a temporary flashing of the pause border on the plot as it is paused while the mousedown event is trigger but mouseup has not yet been.

@michaelrogers michaelrogers mentioned this issue Sep 24, 2021
Merged
8 tasks
nikhilmandlik pushed a commit that referenced this issue Sep 30, 2021
@michaelrogers
Resume plot if no pan, zoom, or drag action is taken (#4138) (#4256)
35eceea
@nikhilmandlik nikhilmandlik linked a pull request Sep 30, 2021 that will close this issue
Resume plot if no pan, zoom, or drag action is taken (#4138) #4256
Merged
8 tasks
@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@shefalijoshi
Copy link
Contributor

Verified fixed except an orange border shows up on mousedown till you mouse up - probably can't be prevented.

@jvigliotta
Copy link
Contributor

Verified fixed - Testathon 9/30 - ditto to what @shefalijoshi said

shefalijoshi added a commit that referenced this issue Oct 26, 2021
@shefalijoshi @akhenry
@jvigliotta @nikhilmandlik @khalidadil @charlesh88 @scottbell @michaelrogers
1.7.8 master (#4373)
510d3bd 
* Notebook conflict auto retry 1.7.7 (#4230)
* Use timeFormatter.parse to get the timestamp of imagery since the source could be something other than key (#4238)
* If there is a pending create request for an id, queue a duplicate request. (#4243)
* [Telemetry Tables] Handling Request Loading (#4245)

* Fix file selection on pressing enter key (#4246)

* starting loading as false, since that makes sense (#4247)

* Hide independent time conductor mode if only 1 mode option is available. (#4250)

* Fix bargraph color selection (#4253)

* snapshot clicked while in edit mode should open in preview mode #4115 (#4257)

* Fix missing object handling in several vues (#4259)

* Flexible Layouts display Condition Sets as their editing/browsing interface (#4179)

* Flexible Layouts display Condition Sets as their editing/browsing interface #4141

* [Telemetry Table] Progress bar tests (#4249)

* Remove alert styling and hide pause button if in Fixed Time mode. (#4263)

* [Table/Collection Fixes] Clearing correctly, no mutating options, no duplicate requests (#4261)

* Condition sets only persist if actively editing (#4262)

* Imagery views should follow time context (#4264)

* Equal stacked plot y widths for all it's sub-plots (#4267)

* Fix Bar Graph related CSS (#4270)

* Bar graph review comment fixes (#4232)

* Mct4196 - Fixes Conditional Styling not being applied when editing a Condition Widget (#4255)

* Fix plot zoom when child of time strip (#4272)

* Resume plot if no pan, zoom, or drag action is taken (#4138) (#4256)

* [Telemetry Collection] No duplicate requests on load (#4274)

* doing the easy thing first (#4278)

* Bargraph time metadata should consider 'source' (#4289)

* Show clicked image in large view (#4280)

* added icon for inspector (#4275)

* Bar graph style nullcheck (#4291)

* Stacked plots need to align the Y axis  (#4286)

* Duplicate Request Fixes (#4295)

* Add braintree sanitize url lib and sanitize form urls (#4296)

* Mct4177 fix for telemetry endpoints with '.' in the key (#4308)

* Remove additional request to load plots when mounted. (#4314)

* Fix plots dup requests (#4324)

* Merging 1.7.8 into master.

Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Co-authored-by: Khalid Adil <khalidadil29@gmail.com>
Co-authored-by: Charles Hacskaylo <charlesh88@gmail.com>
Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: Michael Rogers <michael@mhrogers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resume plot if no pan, zoom, or drag action is taken (#4138) michaelrogers/openmct
7 participants
@nikhilmandlik @davetsay @shefalijoshi @michaelrogers @scottbell @jvigliotta @unlikelyzero