Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Snapshot bugs in exportAsJSON tests #5060

Closed
unlikelyzero opened this issue Apr 12, 2022 · 2 comments · Fixed by #5061
Closed

[e2e] Snapshot bugs in exportAsJSON tests #5060

unlikelyzero opened this issue Apr 12, 2022 · 2 comments · Fixed by #5061
Labels
flake Flaky Tests or CI Results type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

Summary

https://app.circleci.com/pipelines/github/nasa/openmct/9777/workflows/52e28c8e-9678-42be-8898-ce0de15123dd/jobs/31411/tests#failed-test-0

plugins/plot/autoscale.e2e.spec.js:50:10 › ExportAsJSON › autoscale off causes no error from undefined user range 

    Error: Snapshot comparison failed:

    Expected: /root/project/test-results/plugins-plot-autoscale.e2e-ExportAsJSON-autoscale-off-causes-no-error-from-undefined-user-range-chrome/autoscale-canvas-prepan-expected.png
    Received: /root/project/test-results/plugins-plot-autoscale.e2e-ExportAsJSON-autoscale-off-causes-no-error-from-undefined-user-range-chrome/autoscale-canvas-prepan-actual.png
        Diff: /root/project/test-results/plugins-plot-autoscale.e2e-ExportAsJSON-autoscale-off-causes-no-error-from-undefined-user-range-chrome/autoscale-canvas-prepan-diff.png

      66 |             new Promise(r => setTimeout(r, 100))
      67 |                 .then(() => canvas.screenshot())
    > 68 |                 .then(shot => expect(shot).toMatchSnapshot('autoscale-canvas-prepan.png', { maxDiffPixels: 40 }))
         |                                            ^
      69 |         ]);
      70 |
      71 |         let errorCount = 0;

        at /root/project/e2e/tests/plugins/plot/autoscale.e2e.spec.js:68:44
        at async Promise.all (index 1)
        at /root/project/e2e/tests/plugins/plot/autoscale.e2e.spec.js:64:9
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Apr 12, 2022
@unlikelyzero unlikelyzero changed the title [e2e] Snapshot bugs in [e2e] Snapshot bugs in exportAsJSON tests Apr 12, 2022
@unlikelyzero unlikelyzero added the flake Flaky Tests or CI Results label Apr 12, 2022
@trusktr trusktr mentioned this issue Apr 12, 2022
15 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Notes
Run npm run test:e2e:full

@akhenry
Copy link
Contributor

akhenry commented Apr 25, 2022

Verified fixed, though there are other e2e tests failing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake Flaky Tests or CI Results type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants