Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] e2e tests are failing for log plots #5112

Closed
5 tasks
akhenry opened this issue Apr 25, 2022 · 1 comment · Fixed by #5168
Closed
5 tasks

[Plots] e2e tests are failing for log plots #5112

akhenry opened this issue Apr 25, 2022 · 1 comment · Fixed by #5168
Labels
flake Flaky Tests or CI Results type:bug

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 25, 2022

Summary

Our e2e tests fail on log plot tests when I run them locally with the following error:

  2 failed
    [chrome] › plugins/plot/log-plot.e2e.spec.js:30:10 › Log plot tests › Can create a log plot. ===
    [MMOC] › plugins/plot/log-plot.e2e.spec.js:30:10 › Log plot tests › Can create a log plot. =====
  2 passed (1m)
::error file=e2e/tests/plugins/plot/log-plot.e2e.spec.js,title=[chrome] › plugins/plot/log-plot.e2e.spec.js:30:10 › Log plot tests › Can create a log plot.,line=152,col=34::  1) [chrome] › plugins/plot/log-plot.e2e.spec.js:30:10 › Log plot tests › Can create a log plot. ==%0A    Error: expect(received).toBe(expected) // Object.is equality%0A%0A    Expected: 28%0A    Received: 0%0A%0A      150 | async function testLogTicks(page) {%0A      151 |     const yTicks = page.locator('.gl-plot-y-tick-label');%0A    > 152 |     expect(await yTicks.count()).toBe(28);%0A          |                                  ^%0A      153 |     await expect(yTicks.nth(0)).toHaveText('-2.98');%0A      154 |     await expect(yTicks.nth(1)).toHaveText('-2.50');

Expected vs Current Behavior

e2e tests should pass

Steps to Reproduce

  1. npm run test:e2e:full

Environment

  • Open MCT Version: release/2.0.3 378a4ca
  • Deployment Type: dev local

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
@unlikelyzero
Copy link
Collaborator

I didn't realize an issue was filed for this. I've fixed it in this PR #5168

@unlikelyzero unlikelyzero linked a pull request May 11, 2022 that will close this issue
15 tasks
@unlikelyzero unlikelyzero mentioned this issue May 11, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake Flaky Tests or CI Results type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants