Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export as JSON needs an activity modal #7367

Closed
akhenry opened this issue Jan 9, 2024 · 3 comments · Fixed by #7374
Closed

Export as JSON needs an activity modal #7367

akhenry opened this issue Jan 9, 2024 · 3 comments · Fixed by #7374
Labels
type:feature Feature. Required intentional design verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Jan 9, 2024

Is your feature request related to a problem? Please describe.
The "Export As JSON" action can take a long time to execute. Currently users are given no feedback that an export is taking place, so with large exports it can appear that the export has silently failed.

Describe the solution you'd like
A progress or activity overlay informing the user that an export is happening.
@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Jan 10, 2024
@ozyx ozyx mentioned this issue Jan 12, 2024
Merged
15 tasks
@scottbell scottbell mentioned this issue Jan 18, 2024
Merged
15 tasks
@scottbell
Copy link
Contributor

To test:

  1. Use OpenMCT with CouchDB
  2. Load or create a lot of objects
  3. Right click on "My Items" and click "Export as JSON"
  4. Note the nifty progress bar
Screen.Recording.2024-01-18.at.12.17.08.PM.mov

scottbell pushed a commit that referenced this issue Jan 18, 2024
@ozyx
feat(#7367): ProgressBar for ExportAsJSONAction (#7374)
01434ff 
* refactor(ExportAsJSONAction): use private methods

* refactor: remove unnecessary webpack alias

* refactor: lint

* fix: tests for `ExportAsJSONAction`

* test: stabilize `InspectorStylesSpec` tests

* docs: fix jsdocs

* chore: remove dead / redundant code

* refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`

* refactor(ExportAsJSONAction): use `Promise.all` where applicable

* refactor(MenuAPI): one-liner

* feat: add percentage ProgressBar to ExportAsJSONAction

* fix(ProgressBar.vue): v-if conditionals

* test(fix): update mockLocalStorage

* test: fix locators

* test: remove unneeded awaits

* fix: example imagery urls (moved after NASA wordpress migration)

* Revert "refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`"

This reverts commit 4f8403a.

* test(e2e): fix logPlot test

* Revert "Revert "refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`""

This reverts commit 0de6640.

* test(e2e): remove waitForNavigations
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jan 19, 2024
rukmini-bose pushed a commit that referenced this issue Jan 19, 2024
@ozyx @rukmini-bose
feat(#7367): ProgressBar for ExportAsJSONAction (#7374)
8495a75 
* refactor(ExportAsJSONAction): use private methods

* refactor: remove unnecessary webpack alias

* refactor: lint

* fix: tests for `ExportAsJSONAction`

* test: stabilize `InspectorStylesSpec` tests

* docs: fix jsdocs

* chore: remove dead / redundant code

* refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`

* refactor(ExportAsJSONAction): use `Promise.all` where applicable

* refactor(MenuAPI): one-liner

* feat: add percentage ProgressBar to ExportAsJSONAction

* fix(ProgressBar.vue): v-if conditionals

* test(fix): update mockLocalStorage

* test: fix locators

* test: remove unneeded awaits

* fix: example imagery urls (moved after NASA wordpress migration)

* Revert "refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`"

This reverts commit 4f8403a.

* test(e2e): fix logPlot test

* Revert "Revert "refactor(LocalStorageObjectProvider): use `getItem()` and `setItem()`""

This reverts commit 0de6640.

* test(e2e): remove waitForNavigations
@unlikelyzero unlikelyzero mentioned this issue Jan 23, 2024
Merged
15 tasks
@akhenry
Copy link
Contributor Author

akhenry commented Jan 23, 2024 •
edited
Loading

Progress dialog is a thing of beauty. Exporting the entirety of my items caused some weirdness with the progress dialog though. Completion % showed 101% completed.

Screenshot 2024-01-23 at 3 31 25 PM

@akhenry akhenry added the verified Tested or intentionally closed label Jan 23, 2024
@akhenry akhenry removed the verified Tested or intentionally closed label Jan 23, 2024
@shefalijoshi
Copy link
Contributor

Verified on 01/25

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Feature. Required intentional design verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

feat(#7367): ProgressBar for ExportAsJSONAction nasa/openmct
5 participants
@akhenry @shefalijoshi @ozyx @scottbell @unlikelyzero