Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots are respecting independent time context settings, even if not enabled #7737

Open
2 of 7 tasks
davetsay opened this issue May 23, 2024 · 0 comments · May be fixed by #7956
Open
2 of 7 tasks

Plots are respecting independent time context settings, even if not enabled #7737

davetsay opened this issue May 23, 2024 · 0 comments · May be fixed by #7956

Comments

@davetsay
Copy link
Contributor

davetsay commented May 23, 2024

Summary

If you are viewing a plot in realtime mode, pause the plot, then sync the time conductor, Open MCT will prompt you to accept that time conductor will be changed to Fixed time mode. If you have an independent time context and it is in fixed time mode (an assumption because it has never enabled in this use case), but it is not enabled, you do not get the warning message and you are switched to fixed mode in the time conductor. Furthermore, if you use independent time context and pause then sync time, it works, but the UI isn't completely reactive to that change, the independent time context appears to be in realtime mode still when in fact it has switched to fixed.

I assume many other things doing checks or actions on this.timeContext are similarly affected.

Related to settings regarding the Time Conductor Sync warning: #7927
Viper JIRA: VIPERGC-706

Expected vs Current Behavior

Plots should only be listening to ITC if enabled, or time conductor if ITC is not enabled.

Steps to Reproduce

No fixed time change warning prompt

  1. Create an overlay plot, add telemetry to it, and save
  2. View the plot in realtime mode
  3. hover over the plot and click Pause
  4. hover over the plot and click Synchronize with Time Conductor
  5. Observe you get a warning message and are switched to Fixed time mode (This is expected behavior)
  6. Toggle the independent time conductor, then toggle the indepedent time conductor off
  7. Change the time conductor back to realtime mode.
  8. Repeat steps 4 and 5 to pause and sync time with conductor
  9. Observe this time there is no warning message.

Plot display is fixed, but Y-axis is still reacting to new data

  1. Repeat Steps 7-9 of previous test to get in a state where changing time conductor from realtime to fixed time has not given you a warning message before switching
  2. Continue to watch plot. If incoming data would adjust the plot axis, it will do so, even if the plot data is outside of the time conductor and plot display bounds

ITC realtime to fixed time mode dispaly issue

  1. Toggle on independent time conductor on a plot
  2. hover over the plot and click Pause
  3. hover over the plot and click Synchronize with Time Conductor
  4. Observe that the plot does indeed switch to fixed time mode, but the ITC appears to be in realtime mode still (clock icon spinning, blue background). Can click the ITC to expand the pop up as well to observe in fixed.
  5. Observe also the behavior of Plot display is fixed, but Y-axis is still reacting to new data

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment