-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Independent time conductor related handling for plot synchronization. #7956
base: master
Are you sure you want to change the base?
Conversation
…isabled is propagated correctly. Also ensure that global time conductor changes are not picked up by the independent time conductor when the user has enabled it at least once before
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7956 +/- ##
==========================================
+ Coverage 57.57% 65.32% +7.74%
==========================================
Files 678 436 -242
Lines 27428 13648 -13780
Branches 2691 0 -2691
==========================================
- Hits 15793 8915 -6878
+ Misses 11294 4733 -6561
+ Partials 341 0 -341
... and 365 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@shefalijoshi i think the best test is the first example of steps to reproduce:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a couple requests. One is inline, and the other is can you add test coverage?
I'll close the other related PR as this is the correct fix.
// Also emit the mode in case it's different from the previous time context | ||
timeContext.emit( | ||
TIME_CONTEXT_EVENTS.modeChanged, | ||
JSON.parse(JSON.stringify(timeContext.getMode())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use structuredClone
over JSON
cloning, unless there is a good reason not to.
Closes #7737
Describe your changes:
Ensure that the mode set when independent time conductor is enabled/disabled is propagated correctly.
Also ensure that global time conductor changes are not picked up by the independent time conductor when the user has enabled it at least once before
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist