Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] CircleCI refactor for stability and to simplify troubleshooting #4566

Merged
merged 35 commits into from
Dec 14, 2021
Merged

[CI] CircleCI refactor for stability and to simplify troubleshooting #4566

merged 35 commits into from
Dec 14, 2021

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Dec 11, 2021 •
edited
Loading

About this PR

This PR is the second refactor of our CircleCI script. It's designed to make our test results more stable and CI easier to troubleshoot. It cleans up a lot of the unused optimizations we made on the last refactor

  • Implement Cache Busting by Trigger
  • Implement Cache Busting by job configuration
  • Migrate off of node10 where possible (now just linting)
  • Implement some 2.1 features of CircleCI
  • Improve the documentation around CI Troubleshooting
  • Reduce the likelihood that flaky tests are merged by running the tests twice on different platforms
  • Bump the Orb versions
  • Reduce some unused optimizations for matrix work

Closes #4559 and #4560 and #4575

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@codecov
Copy link

codecov bot commented Dec 11, 2021 •
edited
Loading

Codecov Report

Merging #4566 (6b0604b) into master (7c4258d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4566      +/-   ##
==========================================
- Coverage   56.83%   56.83%   -0.01%     
==========================================
  Files         727      727              
  Lines       22819    22819              
  Branches     1628     1628              
==========================================
- Hits        12970    12969       -1     
- Misses       9445     9446       +1     
  Partials      404      404
Impacted Files Coverage Δ
...c/plugins/persistence/couch/CouchObjectProvider.js 81.36% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4258d...6b0604b. Read the comment docs.

@unlikelyzero unlikelyzero changed the title Run more in nightly, jump off of node10 where possible [CI] CircleCI Refactor to support stability and troubleshooting Dec 12, 2021
@unlikelyzero unlikelyzero changed the title [CI] CircleCI Refactor to support stability and troubleshooting [CI] CircleCI refactor for stability and to simplify troubleshooting Dec 13, 2021
@unlikelyzero unlikelyzero mentioned this pull request Dec 13, 2021
Merged
8 tasks
@unlikelyzero unlikelyzero linked an issue Dec 14, 2021 that may be closed by this pull request
[CI] Update CircleCI config so that it is more resilient to changes from test configuration changes for long lived PRs #4560
Closed
@unlikelyzero
Copy link
Collaborator Author

unlikelyzero commented Dec 14, 2021 •
edited
Loading

@scottbell I cannot add you as an official reviewer but am able to spend some time today doing a real-time review at your earliest availability

@unlikelyzero unlikelyzero linked an issue Dec 14, 2021 that may be closed by this pull request
[CI] Implement Cache busting in our CircleCI Config #4575
Closed
trusktr
trusktr approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@trusktr trusktr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. I can't tell if there are any unforeseen issue; perhaps having everyone running this after it is merged will tell.

jvigliotta
jvigliotta approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvigliotta jvigliotta merged commit 08b1c4a into master Dec 14, 2021
@jvigliotta jvigliotta deleted the node10-is-hard branch December 14, 2021 21:43
nikhilmandlik pushed a commit that referenced this pull request Dec 15, 2021
@unlikelyzero @nikhilmandlik
[CI] CircleCI refactor for stability and to simplify troubleshooting (#…
c2d5829 
…4566)

* Run more in nightly, jump off of node10 where possible
* Updated config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@trusktr trusktr trusktr approved these changes

@akhenry akhenry Awaiting requested review from akhenry

@nikhilmandlik nikhilmandlik Awaiting requested review from nikhilmandlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@unlikelyzero @trusktr @jvigliotta