Event Generator now shows data in fixed time mode #4883

scottbell · 2022-02-21T14:55:38Z

Describe your changes:

Changed the event generator to use passed start time instead of using Date.now. Also added a test to ensure this works for dates long in the past.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Unit tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue?

Reviewer Checklist

Changes appear to address issue?
Changes appear not to be breaking changes?
Appropriate unit tests included?
Code style and in-line documentation are appropriate?
Commit messages meet standards?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

scottbell · 2022-02-21T14:57:21Z

example/eventGenerator/EventTelemetryProvider.js

@@ -33,7 +33,7 @@ class EventTelemetryProvider {

    generateData(firstObservedTime, count, startTime, duration, name) {
        const millisecondsSinceStart = startTime - firstObservedTime;
-        const utc = Math.floor(startTime / duration) * duration;
+        const utc = startTime + (count * duration);


allows any request to show data. previous incarnation was showing data well into the future

scottbell · 2022-02-21T14:57:33Z

example/eventGenerator/EventTelemetryProvider.js

@@ -75,15 +75,15 @@ class EventTelemetryProvider {
        const duration = domainObject.telemetry.duration * 1000;
        const size = options.size ? options.size : this.defaultSize;
        const data = [];
-        const firstObservedTime = Date.now();
+        const firstObservedTime = options.start;


just use the start request

scottbell · 2022-02-21T14:58:12Z

example/eventGenerator/EventTelemetryProvider.js

        let count = 0;

        if (options.strategy === 'latest' || options.size === 1) {
            start = end;
        }

        while (start <= end && data.length < size) {
-            const startTime = Date.now() + count;
+            const startTime = options.start + count;


often the time window the user has is far in the past of Date.now, so just use the start that was requested

scottbell · 2022-02-21T14:59:56Z

indexTest.js

@@ -1,3 +1,2 @@
-const testsContext = require.context('.', true, /\/(src|platform|\.\/example)\/.*Spec.js$/);
-
+const testsContext = require.context('.', true, /^\.\/(src|example)\/.*Spec.js$/);


Adjusted regex so that we don't pick up:
./node_modules/fooPackage/src/FooSpec.js
./node_modules/fooPackage/example/FooSpec.js
but we do pick up:
./example/eventGenerator/pluginSpec.js

As the example directory is often released to users, it seems like it should be covered by tests

karma.conf.js

codecov · 2022-02-21T15:15:35Z

Codecov Report

Merging #4883 (1ed540d) into master (0df3373) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4883      +/-   ##
==========================================
- Coverage   50.45%   50.34%   -0.11%     
==========================================
  Files         497      510      +13     
  Lines       18401    18657     +256     
  Branches     1657     1657              
==========================================
+ Hits         9284     9393     +109     
- Misses       8702     8850     +148     
+ Partials      415      414       -1

Impacted Files	Coverage Δ
example/eventGenerator/EventTelemetryProvider.js	`96.96% <100.00%> (ø)`
indexTest.js	`100.00% <100.00%> (ø)`
example/generator/GeneratorProvider.js	`27.58% <0.00%> (ø)`
example/exampleUser/ExampleUserProvider.js	`80.00% <0.00%> (ø)`
example/generator/GeneratorMetadataProvider.js	`71.42% <0.00%> (ø)`
example/generator/plugin.js	`20.00% <0.00%> (ø)`
example/generator/StateGeneratorProvider.js	`22.22% <0.00%> (ø)`
example/eventGenerator/EventMetadataProvider.js	`33.33% <0.00%> (ø)`
example/exampleUser/exampleUserCreator.js	`100.00% <0.00%> (ø)`
example/generator/SinewaveLimitProvider.js	`45.83% <0.00%> (ø)`
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df3373...1ed540d. Read the comment docs.

example/exampleUser/pluginSpec.js

scottbell · 2022-02-22T10:06:03Z

.github/workflows/prcop-config.json

@@ -3,7 +3,7 @@
    {
      "name": "descriptionRegexp",
      "config": {
-        "regexp": "x] Testing instructions",
+        "regexp": "(?i)x] Testing instructions",


@unlikelyzero This was tripping me up as I was using X to check the boxes in the template instead of x

thanks for fixing this. You're not the only one who was using the INCORRECT markdown format ;)

jvigliotta · 2022-03-07T22:37:03Z

@jvigliotta to take a look.

jvigliotta

This looks good to me. Nice work!

fixed issue and added tests

6ea54e7

scottbell changed the title ~~fixed issue and added tests~~ Event Generator now shows data in fixed time mode. #4879 Feb 21, 2022

scottbell changed the title ~~Event Generator now shows data in fixed time mode. #4879~~ Event Generator now shows data in fixed time mode Feb 21, 2022

scottbell commented Feb 21, 2022

View reviewed changes

karma.conf.js Show resolved Hide resolved

exclude leaky test

7a97c2e

scottbell commented Feb 21, 2022

View reviewed changes

example/exampleUser/pluginSpec.js Show resolved Hide resolved

scottbell requested review from akhenry, jvigliotta and unlikelyzero February 21, 2022 15:20

ignore case when looking for testing instructions

6cd6d6f

scottbell commented Feb 22, 2022

View reviewed changes

scottbell added 2 commits February 22, 2022 11:08

ignore case when looking for testing instructions

5f9b97d

revert changes

0d466d0

unlikelyzero approved these changes Feb 22, 2022

View reviewed changes

scottbell added 3 commits February 23, 2022 12:04

Merge branch 'master' into mct4879

47bebe6

Merge branch 'master' into mct4879

391fd26

Merge branch 'master' into mct4879

e73f83c

scottbell and others added 5 commits March 14, 2022 15:03

Merge branch 'master' into mct4879

0375053

Merge branch 'master' into mct4879

55b3b3b

Merge branch 'master' into mct4879

918ec37

Merge branch 'master' into mct4879

e210d86

Merge branch 'master' into mct4879

1ed540d

jvigliotta approved these changes Mar 21, 2022

View reviewed changes

jvigliotta merged commit 28d5d72 into master Mar 21, 2022

jvigliotta deleted the mct4879 branch March 21, 2022 22:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event Generator now shows data in fixed time mode #4883

Event Generator now shows data in fixed time mode #4883

scottbell commented Feb 21, 2022 •

edited by jvigliotta

Loading

scottbell Feb 21, 2022

scottbell Feb 21, 2022

scottbell Feb 21, 2022

scottbell Feb 21, 2022

codecov bot commented Feb 21, 2022 •

edited

Loading

scottbell Feb 22, 2022

unlikelyzero Feb 22, 2022

jvigliotta commented Mar 7, 2022

jvigliotta left a comment

		@@ -1,3 +1,2 @@
		const testsContext = require.context('.', true, /\/(src\|platform\|\.\/example)\/.*Spec.js$/);

		const testsContext = require.context('.', true, /^\.\/(src\|example)\/.*Spec.js$/);

Event Generator now shows data in fixed time mode #4883

Event Generator now shows data in fixed time mode #4883

Conversation

scottbell commented Feb 21, 2022 • edited by jvigliotta Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

scottbell Feb 21, 2022

Choose a reason for hiding this comment

scottbell Feb 21, 2022

Choose a reason for hiding this comment

scottbell Feb 21, 2022

Choose a reason for hiding this comment

scottbell Feb 21, 2022

Choose a reason for hiding this comment

codecov bot commented Feb 21, 2022 • edited Loading

Codecov Report

scottbell Feb 22, 2022

Choose a reason for hiding this comment

unlikelyzero Feb 22, 2022

Choose a reason for hiding this comment

jvigliotta commented Mar 7, 2022

jvigliotta left a comment

Choose a reason for hiding this comment

scottbell commented Feb 21, 2022 •

edited by jvigliotta

Loading

codecov bot commented Feb 21, 2022 •

edited

Loading