Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested composition add fix #5134

Closed
wants to merge 20 commits into from
Closed

Nested composition add fix #5134

wants to merge 20 commits into from

Conversation

davetsay
Copy link
Contributor

Closes #5033

Describe your changes:

  • Select domain object to add composition by clicking domain object element in Object View.
  • TODO - enhancement to limit selection only when the hovered over domain object is composable

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi and others added 17 commits April 25, 2022 11:58
@shefalijoshi
Release 2.0.3
378a4ca
@shefalijoshi
Fix tick values for plots ticks in log mode and null check (#5119)
286a533 
* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off.

* If the formatted value is a number and a float, set precision to 2 decimal points.

* Fix value assignment

* Use whole numbers in log mode

* Revert whole numbers fix - need floats for values between 0 and 1.
@davetsay
webpack dev build source mapping test
f957b0c
@davetsay
revert source map test. success.
82bf48b
@shefalijoshi
Handle scrolling to focused image on resize/new data (#5121)
ce28dd2 
* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode

* Scroll to the right if there is no paused focused image
@jvigliotta
[LAD Tables] Use Telemetry Collections (#5127)
3d2d932 
* Use telemetry collections to handle bounds checks
@jvigliotta
added telemetry collection to alphanumeric telemetry view (#5131)
b7b2056
@michaelrogers
Added animation styling for POS and CAM; adjusted cutoff for isNewIma…
2519e60 
…ge (#5116)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage

* Remove animation from POS and CAM
@davetsay
use object (map) instead of set to track dirty objects
843f457
@davetsay
Merge branch 'master' into composition-fix
618480e
@davetsay
fix tests due to internals change
74791ba
@davetsay
Merge branch 'composition-fix' of github.com:nasa/openmct into compos…
bfb7d0c 
…ition-fix
@davetsay
Merge branch 'release/2.0.3' into composition-fix
8c25891
@davetsay
remove sneaky code from other pr
dde5a7c
@davetsay @nikhilmandlik
Fix transactions overwriting latest objects with stale objects on save (
8b4a55a 
#5132)

* use object (map) instead of set to track dirty objects
* fix tests due to internals change

Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
@davetsay
select object on dragenter
129ac0a
@davetsay
Merge branch 'release/2.0.3' into nested-composition-fix
565f0fb
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/2.0.5@60d021e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/2.0.5    #5134   +/-   ##
================================================
  Coverage                 ?   49.57%           
================================================
  Files                    ?      589           
  Lines                    ?    21565           
  Branches                 ?     2020           
================================================
  Hits                     ?    10690           
  Misses                   ?    10333           
  Partials                 ?      542

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d021e...9aadf3c. Read the comment docs.

@shefalijoshi shefalijoshi self-requested a review April 28, 2022 20:30
@davetsay davetsay changed the base branch from release/2.0.3 to master April 28, 2022 20:58
@davetsay davetsay marked this pull request as draft April 28, 2022 20:59
@davetsay davetsay requested a review from akhenry April 28, 2022 20:59
@akhenry akhenry mentioned this pull request May 2, 2022
Closed
5 tasks
@shefalijoshi
Copy link
Contributor

@davetsay Please resolve conflicts.

@davetsay davetsay changed the base branch from master to release/2.0.5 June 16, 2022 23:15
@davetsay
Copy link
Contributor Author

Not needed

@davetsay davetsay closed this Jun 23, 2022
@davetsay davetsay deleted the nested-composition-fix branch June 23, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefalijoshi shefalijoshi Awaiting requested review from shefalijoshi

@akhenry akhenry Awaiting requested review from akhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LAD Tables][Display Layout] LAD Table in Display Layout Composition Issues
4 participants
@davetsay @shefalijoshi @jvigliotta @michaelrogers