PR Cop 2.0 #5815

unlikelyzero · 2022-09-28T18:07:26Z

Contributes towards /issues/5755

Describe your changes:

Enforces a type label
Enforces a milestone

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Changes appear not to be breaking changes?
Appropriate unit tests included?
Code style and in-line documentation are appropriate?
Commit messages meet standards?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

codecov · 2022-09-28T18:12:19Z

Codecov Report

Merging #5815 (86d5be5) into master (97bffc5) will decrease coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5815      +/-   ##
==========================================
- Coverage   55.90%   55.67%   -0.23%     
==========================================
  Files         655      655              
  Lines       26316    26316              
  Branches     2543     2543              
==========================================
- Hits        14712    14652      -60     
- Misses      10892    10956      +64     
+ Partials      712      708       -4

Flag	Coverage Δ		*Carryforward flag
e2e-full	`41.86% <ø> (ø)`		Carriedforward from 3f2dbdf
e2e-stable	`58.49% <ø> (+0.08%)`	⬆️
unit	`48.76% <ø> (-0.40%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 16 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97bffc5...86d5be5. Read the comment docs.

ozyx

Looks good!
Couple questions:

With this change, every PR must have either a milestone or the "no milestone" label?
What does the developer see if a PR fails merge check due to missing milestone or type: label? Is it clear enough?

jvigliotta · 2022-10-17T23:12:40Z

.github/PULL_REQUEST_TEMPLATE.md

+* [ ] Have you followed the guidelines in our [Contributing document](https://github.com/nasa/openmct/blob/master/CONTRIBUTING.md)?
+* [ ] Have you associated this PR with a `type:` label?
+* [ ] Have you associated a milestone with this PR?
+* [ ] Testing instructions included in associated issue OR is this a dependency/testcase change?
 ### Author Checklist


can we just get a space before this to be consistent with the other headers?

jvigliotta · 2022-10-17T23:13:07Z

.github/PULL_REQUEST_TEMPLATE.md

 * [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/nasa/openmct/pulls) for the same update/change?
 * [ ] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

+### Contribution Checklist


Should we note that both authors and reviewers should verify this section?

Yeah I'm confused about who the intended audience is here. How does it differ from the author checklist?

jvigliotta

Looks good! Just a suggestion and a formatting fix.

.github/PULL_REQUEST_TEMPLATE.md

akhenry · 2022-10-21T19:57:40Z

.github/PULL_REQUEST_TEMPLATE.md

 * [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/nasa/openmct/pulls) for the same update/change?
 * [ ] Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

+### Contribution Checklist


Yeah I'm confused about who the intended audience is here. How does it differ from the author checklist?

charlesh88

How does one know how to set a milestone? Can the system not require a milestone, but add "No milestone" if one isn't entered?
Similar question about type labels. Like the idea of automatically pulling from an issue, but what if the user hasn't tied an issue to the PR?

ozyx

I have some outstanding questions, didn't mark as "request changes" before, so marking that now so it's shown as reviewed

akhenry · 2023-01-09T21:39:44Z

@shefalijoshi to review

jvigliotta · 2023-01-12T20:34:02Z

@unlikelyzero were you able to address my comments? I'm not seeing it

.github/PULL_REQUEST_TEMPLATE.md

deploysentinel · 2023-12-14T14:48:34Z

Current Playwright Test Results Summary

✅ 165 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/14/2023 03:09:01pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 86d5be5

Started: 12/14/2023 03:01:24pm UTC

⚠️ Flakes

📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds Retry 2 • Retry 1 • Initial Attempt	0% (0) 0 / 39 runs failed over last 7 days	17.95% (7) 7 / 39 runs flaked over last 7 days

📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 39 runs failed over last 7 days	41.03% (16) 16 / 39 runs flaked over last 7 days

📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image Retry 1 • Initial Attempt	0% (0) 0 / 39 runs failed over last 7 days	15.38% (6) 6 / 39 runs flaked over last 7 days

📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry Retry 1 • Initial Attempt	0% (0) 0 / 38 runs failed over last 7 days	57.89% (22) 22 / 38 runs flaked over last 7 days

View Detailed Build Results

unlikelyzero · 2023-12-14T15:25:48Z

Yeah I'm confused about who the intended audience is here. How does it differ from the author checklist?
@akhenry it meant that ownership was shared by everyone and not something that the author or reviewer had to follow explicitly. The intent was for the release manager to set this if not already set

unlikelyzero · 2023-12-14T15:32:31Z

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,8 +14,10 @@ Closes <!--- Insert Issue Number(s) this PR addresses. Start by typing # will op

 * [ ] Changes address original issue?
 * [ ] Tests included and/or updated with changes?
-* [ ] Command line build passes?


no longer necessary with our ci

jvigliotta

LGTM!

PR Cop

83702b8

unlikelyzero added this to the Target:2.1.1 milestone Sep 28, 2022

unlikelyzero added the type:maintenance tests, chores, or project maintenance label Sep 28, 2022

unlikelyzero added 2 commits September 30, 2022 09:36

Merge branch 'master' into pr-cop-two

2536a78

Update the PR Template

dab8c85

unlikelyzero modified the milestones: Target:2.1.1, Target:2.1.2 Sep 30, 2022

akhenry requested a review from ozyx October 3, 2022 20:51

ozyx reviewed Oct 13, 2022

View reviewed changes

akhenry requested review from akhenry, charlesh88, davetsay, jvigliotta, khalidadil, michaelrogers, ozyx, rukmini-bose, scottbell and shefalijoshi October 17, 2022 21:03

scottbell approved these changes Oct 17, 2022

View reviewed changes

rukmini-bose approved these changes Oct 17, 2022

View reviewed changes

jvigliotta reviewed Oct 17, 2022

View reviewed changes

jvigliotta requested changes Oct 17, 2022

View reviewed changes

khalidadil reviewed Oct 18, 2022

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved

khalidadil approved these changes Oct 18, 2022

View reviewed changes

akhenry requested changes Oct 21, 2022

View reviewed changes

unlikelyzero modified the milestones: Target:2.1.2, 2.1.3 Nov 10, 2022

unlikelyzero modified the milestones: Target:2.1.3, Target:2.1.4 Nov 17, 2022

charlesh88 reviewed Dec 6, 2022

View reviewed changes

ozyx modified the milestones: Target:2.1.4, Target:2.1.5 Dec 6, 2022

davetsay approved these changes Dec 19, 2022

View reviewed changes

michaelrogers approved these changes Dec 19, 2022

View reviewed changes

ozyx requested changes Dec 20, 2022

View reviewed changes

unlikelyzero modified the milestones: Target:2.1.5, Target:2.1.6 Dec 28, 2022

shefalijoshi requested changes Jan 17, 2023

View reviewed changes

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved

unlikelyzero removed this from the Target:2.1.6 milestone Jan 20, 2023

Merge branch 'master' into pr-cop-two

3f2dbdf

unlikelyzero added this to the Target:3.3.0 milestone Dec 14, 2023

address review comments

86d5be5

unlikelyzero requested review from shefalijoshi, jvigliotta, ozyx and akhenry December 14, 2023 15:26

unlikelyzero commented Dec 14, 2023

View reviewed changes

jvigliotta approved these changes Dec 14, 2023

View reviewed changes

unlikelyzero merged commit 4075a31 into master Dec 14, 2023
14 of 15 checks passed

unlikelyzero deleted the pr-cop-two branch December 14, 2023 18:55

unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR Cop 2.0 #5815

PR Cop 2.0 #5815

unlikelyzero commented Sep 28, 2022 •

edited by ozyx

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

ozyx left a comment

jvigliotta Oct 17, 2022

jvigliotta Oct 17, 2022

akhenry Oct 21, 2022

jvigliotta left a comment

akhenry Oct 21, 2022

charlesh88 left a comment

ozyx left a comment

akhenry commented Jan 9, 2023

jvigliotta commented Jan 12, 2023

deploysentinel bot commented Dec 14, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

unlikelyzero commented Dec 14, 2023

unlikelyzero Dec 14, 2023

jvigliotta left a comment

PR Cop 2.0 #5815

PR Cop 2.0 #5815

Conversation

unlikelyzero commented Sep 28, 2022 • edited by ozyx Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Sep 28, 2022 • edited Loading

Codecov Report

ozyx left a comment

Choose a reason for hiding this comment

jvigliotta Oct 17, 2022

Choose a reason for hiding this comment

jvigliotta Oct 17, 2022

Choose a reason for hiding this comment

akhenry Oct 21, 2022

Choose a reason for hiding this comment

jvigliotta left a comment

Choose a reason for hiding this comment

akhenry Oct 21, 2022

Choose a reason for hiding this comment

charlesh88 left a comment

Choose a reason for hiding this comment

ozyx left a comment

Choose a reason for hiding this comment

akhenry commented Jan 9, 2023

jvigliotta commented Jan 12, 2023

deploysentinel bot commented Dec 14, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

unlikelyzero commented Dec 14, 2023

unlikelyzero Dec 14, 2023

Choose a reason for hiding this comment

jvigliotta left a comment

Choose a reason for hiding this comment

unlikelyzero commented Sep 28, 2022 •

edited by ozyx

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

deploysentinel bot commented Dec 14, 2023 •

edited

Loading