Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds limits subscription to the Telemetry API #6735

Merged
merged 12 commits into from
Jul 15, 2023
Merged

Adds limits subscription to the Telemetry API #6735

merged 12 commits into from
Jul 15, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jun 14, 2023 •
edited by akhenry
Loading

Closes VIPEROMCT-295

Describe your changes:

Adds a subscribeToLimits method to the telemetry API
See related PR here: akhenry/openmct-yamcs#333

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jun 14, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/15/2023 12:08:46am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 72272c9

Started: 07/15/2023 12:02:50am UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt
8.51% (4) 4 / 47 runs
failed over last 7 days
63.83% (30) 30 / 47 runs
flaked over last 7 days

View Detailed Build Results

Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/15/2023 12:08:46am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 72272c9

Started: 07/15/2023 12:01:55am UTC

⚠️ Flakes

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 1 • Initial Attempt
39.64% (67) 67 / 169 runs
failed over last 7 days
5.92% (10) 10 / 169 runs
flaked over last 7 days
📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt
0.57% (1) 1 / 176 run
failed over last 7 days
76.70% (135) 135 / 176 runs
flaked over last 7 days

View Detailed Build Results

@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Merging #6735 (adf0a19) into master (662d143) will decrease coverage by 4.27%.
The diff coverage is 86.20%.

❗ Current head adf0a19 differs from pull request most recent head 72272c9. Consider uploading reports for the commit 72272c9 to get more accurate results

@@            Coverage Diff             @@
##           master    #6735      +/-   ##
==========================================
- Coverage   58.03%   53.76%   -4.27%     
==========================================
  Files         402      631     +229     
  Lines       12233    25144   +12911     
  Branches        0     2516    +2516     
==========================================
+ Hits         7099    13518    +6419     
- Misses       5134    10953    +5819     
- Partials        0      673     +673
Flag Coverage Δ *Carryforward flag
e2e-full 42.20% <ø> (-0.08%) ⬇️ Carriedforward from 28f6e99
e2e-stable 55.56% <82.75%> (+0.20%) ⬆️
unit 48.29% <86.20%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/api/telemetry/TelemetryAPI.js 91.82% <80.95%> (+12.14%) ⬆️
src/plugins/plot/configuration/PlotSeries.js 84.57% <100.00%> (+1.14%) ⬆️

... and 376 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662d143...72272c9. Read the comment docs.

@unlikelyzero unlikelyzero added this to the Target:2.2.6 milestone Jun 20, 2023
@unlikelyzero unlikelyzero added the pr:platform Runs tests against all supported platforms label Jun 20, 2023
jvigliotta
jvigliotta approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'll wait on @akhenry before merging since it's API.

akhenry
akhenry requested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one suggestion on documentation.

Also we need some tests.

src/api/telemetry/TelemetryAPI.js Outdated Show resolved Hide resolved
@akhenry akhenry mentioned this pull request Jun 30, 2023
Merged
15 tasks
@shefalijoshi shefalijoshi requested a review from akhenry July 7, 2023 17:26
@shefalijoshi
Copy link
Contributor Author

Added tests here: akhenry/openmct-yamcs#333

akhenry
akhenry requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this PR look good, but comment on openmct-yamcs PR needs addressed - akhenry/openmct-yamcs#333 (review)

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
@akhenry akhenry enabled auto-merge (squash) July 15, 2023 00:00
@github-actions github-actions bot removed the pr:platform Runs tests against all supported platforms label Jul 15, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 15, 2023
@akhenry akhenry merged commit 5b1298f into master Jul 15, 2023
@akhenry akhenry deleted the telemetry-api-limits-subscription branch July 15, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@akhenry akhenry akhenry approved these changes

Assignees
No one assigned
Labels
type:feature Feature. Required intentional design
Projects
None yet
Milestone
Target:3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shefalijoshi @akhenry @jvigliotta @unlikelyzero