-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed global time to use time context current value for ITC #7191
Conversation
Current Playwright Test Results Summary✅ 157 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/13/2023 06:44:04pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time conductor input fields real-time mode validate input fields in real-time mode
Retry 1 • Initial Attempt |
0% (0)0 / 125 runsfailed over last 7 days |
2.40% (3)3 / 125 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
3.14% (5)5 / 159 runsfailed over last 7 days |
56.60% (90)90 / 159 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
0% (0)0 / 129 runsfailed over last 7 days |
66.67% (86)86 / 129 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 129 runsfailed over last 7 days |
24.03% (31)31 / 129 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/13/2023 06:44:04pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 0e8fa4c
Started: 11/13/2023 06:37:26pm UTC
⚠️ Flakes
📄 functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
0% (0)0 / 41 runsfailed over last 7 days |
12.20% (5)5 / 41 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7191 +/- ##
===========================================
- Coverage 55.02% 41.47% -13.55%
===========================================
Files 653 414 -239
Lines 26213 12737 -13476
Branches 2525 0 -2525
===========================================
- Hits 14424 5283 -9141
+ Misses 11083 7454 -3629
+ Partials 706 0 -706
*This pull request uses carry forward flags. Click here to find out more. see 504 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Verified Testathon 11/13/23 -- Global clock remains unchanged |
Closes #7223
Describe your changes:
Changed the independent time conductor to use the time context value instead of the global openmct clock value. This resolves an error where the independent time conductor always shows the global clock time instead of the intended independent time mode.
All Submissions:
Author Checklist
Reviewer Checklist