Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed global time to use time context current value for ITC #7191

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

michaelrogers
Copy link
Contributor

@michaelrogers michaelrogers commented Oct 31, 2023

Closes #7223

Describe your changes:

Changed the independent time conductor to use the time context value instead of the global openmct clock value. This resolves an error where the independent time conductor always shows the global clock time instead of the intended independent time mode.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 31, 2023

Current Playwright Test Results Summary

✅ 157 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/13/2023 06:44:04pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 0e8fa4c

Started: 11/13/2023 06:36:53pm UTC

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor input fields real-time mode validate input fields in real-time mode
Retry 1Initial Attempt
0% (0) 0 / 125 runs
failed over last 7 days
2.40% (3) 3 / 125 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
3.14% (5) 5 / 159 runs
failed over last 7 days
56.60% (90) 90 / 159 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
0% (0) 0 / 129 runs
failed over last 7 days
66.67% (86) 86 / 129 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 129 runs
failed over last 7 days
24.03% (31) 31 / 129 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/13/2023 06:44:04pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 0e8fa4c

Started: 11/13/2023 06:37:26pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 41 runs
failed over last 7 days
12.20% (5) 5 / 41 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7191 (e90b038) into master (deacd91) will decrease coverage by 13.55%.
The diff coverage is n/a.

❗ Current head e90b038 differs from pull request most recent head 0e8fa4c. Consider uploading reports for the commit 0e8fa4c to get more accurate results

@@             Coverage Diff             @@
##           master    #7191       +/-   ##
===========================================
- Coverage   55.02%   41.47%   -13.55%     
===========================================
  Files         653      414      -239     
  Lines       26213    12737    -13476     
  Branches     2525        0     -2525     
===========================================
- Hits        14424     5283     -9141     
+ Misses      11083     7454     -3629     
+ Partials      706        0      -706     
Flag Coverage Δ *Carryforward flag
e2e-full 41.47% <ø> (-0.38%) ⬇️ Carriedforward from 8c8d6d5
e2e-stable ?
unit ?

*This pull request uses carry forward flags. Click here to find out more.

see 504 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deacd91...0e8fa4c. Read the comment docs.

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jvigliotta jvigliotta enabled auto-merge (squash) November 8, 2023 18:16
@ozyx ozyx disabled auto-merge November 10, 2023 12:16
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 13, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 13, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 13, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 13, 2023
@michaelrogers michaelrogers merged commit 7f8262b into master Nov 13, 2023
14 of 15 checks passed
@michaelrogers michaelrogers deleted the vomct398 branch November 13, 2023 21:42
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 13, 2023
@ozyx
Copy link
Contributor

ozyx commented Nov 13, 2023

Verified Testathon 11/13/23 -- Global clock remains unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Independent time conductor shows local clock time when remote clock selected
4 participants