Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior with multiple annotations in imagery #7261

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Nov 28, 2023

Closes #7170

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Nov 28, 2023 that may be closed by this pull request
7 tasks
Copy link

deploysentinel bot commented Nov 28, 2023

Current Playwright Test Results Summary

✅ 164 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/05/2023 03:08:15am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: d5d61c1

Started: 12/05/2023 03:00:03am UTC

⚠️ Flakes

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
0% (0) 0 / 47 runs
failed over last 7 days
19.15% (9) 9 / 47 runs
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 50 runs
failed over last 7 days
32% (16) 16 / 50 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 72 runs
failed over last 7 days
59.72% (43) 43 / 72 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 49 runs
failed over last 7 days
30.61% (15) 15 / 49 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
2% (1) 1 / 50 run
failed over last 7 days
58% (29) 29 / 50 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/05/2023 03:08:15am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: d5d61c1

Started: 12/05/2023 03:00:16am UTC

View Detailed Build Results


Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #7261 (d5d61c1) into master (a3e0a0f) will increase coverage by 0.16%.
The diff coverage is 4.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7261      +/-   ##
==========================================
+ Coverage   55.70%   55.86%   +0.16%     
==========================================
  Files         654      655       +1     
  Lines       26265    26286      +21     
  Branches     2538     2540       +2     
==========================================
+ Hits        14630    14685      +55     
+ Misses      10930    10888      -42     
- Partials      705      713       +8     
Flag Coverage Δ
e2e-full 41.87% <ø> (ø)
e2e-stable 58.28% <100.00%> (-0.09%) ⬇️
unit 49.17% <4.34%> (+0.35%) ⬆️
Files Coverage Δ
...ectorViews/annotations/tags/TagEditorClassNames.js 100.00% <100.00%> (ø)
...gins/inspectorViews/annotations/tags/TagEditor.vue 0.00% <0.00%> (ø)
src/plugins/notebook/components/NotebookEntry.vue 15.26% <0.00%> (-0.09%) ⬇️
...ctorViews/annotations/AnnotationsInspectorView.vue 0.00% <0.00%> (ø)
...s/inspectorViews/annotations/tags/TagSelection.vue 0.00% <0.00%> (ø)
.../plugins/notebook/components/NotebookComponent.vue 17.84% <0.00%> (-0.05%) ⬇️
src/plugins/plot/MctPlot.vue 36.11% <0.00%> (-0.15%) ⬇️
...c/plugins/imagery/components/AnnotationsCanvas.vue 2.23% <0.00%> (-0.21%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e0a0f...d5d61c1. Read the comment docs.

@scottbell scottbell changed the title 7170 inconsistent behavior with multiple annotations in imagery Inconsistent behavior with multiple annotations in imagery Nov 28, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 29, 2023
@scottbell scottbell marked this pull request as ready for review November 29, 2023 15:29
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 29, 2023
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor code cleanup suggestions. Good work

src/plugins/imagery/components/AnnotationsCanvas.vue Outdated Show resolved Hide resolved
src/plugins/imagery/components/AnnotationsCanvas.vue Outdated Show resolved Hide resolved
src/plugins/imagery/components/AnnotationsCanvas.vue Outdated Show resolved Hide resolved
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
…-imagery' of github.com:nasa/openmct into 7170-inconsistent-behavior-with-multiple-annotations-in-imagery
@scottbell scottbell added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Dec 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 1, 2023
@@ -0,0 +1,9 @@
const TagEditorClassNames = Object.freeze({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

await page.getByText('Drilling').click();
await expect(page.getByText('Driving')).toBeVisible();
await expect(page.getByText('Science')).toBeVisible();
await expect(page.getByText('Drilling')).toBeVisible();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 5, 2023
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 5, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 5, 2023
@unlikelyzero unlikelyzero merged commit 2d9c041 into master Dec 5, 2023
14 of 15 checks passed
@unlikelyzero unlikelyzero deleted the 7170-inconsistent-behavior-with-multiple-annotations-in-imagery branch December 5, 2023 03:12
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior with multiple annotations in imagery
3 participants