-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent behavior with multiple annotations in imagery #7261
Inconsistent behavior with multiple annotations in imagery #7261
Conversation
…ehavior-with-multiple-annotations-in-imagery
…nnotations-in-imagery
Current Playwright Test Results Summary✅ 164 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/05/2023 03:08:15am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 47 runsfailed over last 7 days |
19.15% (9)9 / 47 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 50 runsfailed over last 7 days |
32% (16)16 / 50 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 72 runsfailed over last 7 days |
59.72% (43)43 / 72 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 49 runsfailed over last 7 days |
30.61% (15)15 / 49 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
2% (1)1 / 50 runfailed over last 7 days |
58% (29)29 / 50 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 12/05/2023 03:08:15am UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: d5d61c1
Started: 12/05/2023 03:00:16am UTC
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7261 +/- ##
==========================================
+ Coverage 55.70% 55.86% +0.16%
==========================================
Files 654 655 +1
Lines 26265 26286 +21
Branches 2538 2540 +2
==========================================
+ Hits 14630 14685 +55
+ Misses 10930 10888 -42
- Partials 705 713 +8
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor code cleanup suggestions. Good work
Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
…nnotations-in-imagery
…-imagery' of github.com:nasa/openmct into 7170-inconsistent-behavior-with-multiple-annotations-in-imagery
@@ -0,0 +1,9 @@ | |||
const TagEditorClassNames = Object.freeze({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
await page.getByText('Drilling').click(); | ||
await expect(page.getByText('Driving')).toBeVisible(); | ||
await expect(page.getByText('Science')).toBeVisible(); | ||
await expect(page.getByText('Drilling')).toBeVisible(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
…nnotations-in-imagery
Closes #7170
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist