Destroy canvas in plots if not visible #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/04/2023 09:28:14pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f9657f5 Started: 12/04/2023 09:26:44pm UTC Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 12/04/2023 09:28:14pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 42 runsfailed over last 7 days |
28.57% (12)12 / 42 runsflaked over last 7 days |
📄 functional/plugins/tabs/tabs.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Tabs View Renders tabbed elements
Retry 1 • Initial Attempt |
0% (0)0 / 40 runsfailed over last 7 days |
2.50% (1)1 / 40 runflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.56% (1)1 / 64 runfailed over last 7 days |
53.13% (34)34 / 64 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
2.44% (1)1 / 41 runfailed over last 7 days |
34.15% (14)14 / 41 runsflaked over last 7 days |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
==========================================
- Coverage 56.04% 56.01% -0.04%
==========================================
Files 654 654
Lines 26229 26256 +27
Branches 2528 2536 +8
==========================================
+ Hits 14699 14706 +7
- Misses 10828 10845 +17
- Partials 702 705 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Fun to watch the canvas being destroyed: Screen.Recording.2023-11-30.at.1.56.47.PM.mov |
| // expect two canvases (i.e., overlay & main canvas for sine wave generator) to be visible | ||
| await expect(page.locator('canvas')).toHaveCount(2); | ||
| await expect(page.locator('canvas').nth(0)).toBeVisible(); | ||
| await expect(page.locator('canvas').nth(1)).toBeVisible(); |
ozyx
approved these changes
Dec 4, 2023
…ext-when-not-visible
ozyx
deleted the
7202-have-webgl-contexts-eagerly-lose-context-when-not-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7202
Describe your changes:
Add an intersection observer to destroy the canvas when we've detected we're not visible.
All Submissions:
Author Checklist
Reviewer Checklist