Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove unneeded parameterization and increase parallelism #7310

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Dec 18, 2023

Describe your changes:

  • Driveby: Removed unneeded parameterization
  • Increase parallelism
  • split up performance tests

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 18, 2023
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Dec 18, 2023
Copy link

deploysentinel bot commented Dec 18, 2023

Current Playwright Test Results Summary

✅ 15 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/19/2023 12:40:05am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: bd5b220

Started: 12/19/2023 12:35:13am UTC

⚠️ Flakes

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1Initial Attempt
0% (0) 0 / 34 runs
failed over last 7 days
14.71% (5) 5 / 34 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 165 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 12/19/2023 12:40:05am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: bd5b220

Started: 12/19/2023 12:34:53am UTC

⚠️ Flakes

📄   functional/planning/ganttChart.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Gantt Chart Displays a Plan's draft status
Retry 1Initial Attempt
0% (0) 0 / 91 runs
failed over last 7 days
2.20% (2) 2 / 91 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
4.40% (4) 4 / 91 runs
failed over last 7 days
58.24% (53) 53 / 91 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 68 runs
failed over last 7 days
51.47% (35) 35 / 68 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 68 runs
failed over last 7 days
20.59% (14) 14 / 68 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.54% (1) 1 / 65 run
failed over last 7 days
56.92% (37) 37 / 65 runs
flaked over last 7 days

View Detailed Build Results


Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #7310 (ac02116) into master (3fccac0) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head ac02116 differs from pull request most recent head bd5b220. Consider uploading reports for the commit bd5b220 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7310      +/-   ##
==========================================
- Coverage   55.98%   55.61%   -0.37%     
==========================================
  Files         655      655              
  Lines       26327    26327              
  Branches     2544     2544              
==========================================
- Hits        14738    14643      -95     
- Misses      10891    10984      +93     
- Partials      698      700       +2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.85% <ø> (-0.01%) ⬇️ Carriedforward from 1ee09a2
e2e-stable 58.40% <ø> (-0.04%) ⬇️
unit 48.73% <ø> (-0.51%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fccac0...bd5b220. Read the comment docs.

@ozyx ozyx self-requested a review December 19, 2023 00:20
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one minor proposal on job name change

@unlikelyzero unlikelyzero enabled auto-merge (squash) December 19, 2023 00:32
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@unlikelyzero unlikelyzero merged commit 0ce36c8 into master Dec 19, 2023
16 of 17 checks passed
@unlikelyzero unlikelyzero deleted the speedup-ci branch December 19, 2023 00:48
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants