Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Imagery positional freshness label from 'POS' to 'ROV' #7409

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

charlesh88
Copy link
Contributor

Closes #7404. Note that this is critical in order to be in parity with the same display in VERVE.

Describe your changes:

Title says it all.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Change 'POS' to 'ROV'.
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1148644) 55.97% compared to head (be94b3d) 56.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7409      +/-   ##
==========================================
+ Coverage   55.97%   56.01%   +0.04%     
==========================================
  Files         660      660              
  Lines       26282    26282              
  Branches     2550     2550              
==========================================
+ Hits        14711    14723      +12     
+ Misses      10860    10848      -12     
  Partials      711      711              
Flag Coverage Δ
e2e-full 41.97% <ø> (ø)
e2e-stable 60.22% <ø> (+0.15%) ⬆️
unit 48.92% <ø> (-0.01%) ⬇️
Files Coverage Δ
src/plugins/imagery/components/ImageryView.vue 40.19% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1148644...be94b3d. Read the comment docs.

@unlikelyzero unlikelyzero enabled auto-merge (squash) January 25, 2024 05:17
@unlikelyzero unlikelyzero self-requested a review January 25, 2024 05:17
@unlikelyzero unlikelyzero merged commit 0340fe1 into master Jan 25, 2024
33 checks passed
@unlikelyzero unlikelyzero deleted the change-POS-7404 branch January 25, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Imagery positional freshness from 'POS' to 'ROV'
2 participants