-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collapse to Recent Objects #7502
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7502 +/- ##
=======================================
Coverage 55.37% 55.38%
=======================================
Files 671 671
Lines 27012 27013 +1
Branches 2632 2633 +1
=======================================
+ Hits 14959 14960 +1
+ Misses 11330 11329 -1
- Partials 723 724 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
We should add some visual tests (or modify existing tests) to cover Recent Objects, I'm not sure if we have any |
<pane | ||
handle="before" | ||
label="Recently Viewed" | ||
:persist-position="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't need to be bound to anything as it's constant
:persist-position="true" | |
persist-position="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was wrong about this. If we're passing a boolean, we need the :v-bind
otherwise it gets passed as a string. Just Vue 3 Things
This reverts commit ce2ea42.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work, this looks great. In a separate PR, we should update the default starting position of the panel to be higher for visibility.
Closes #7491
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist