fix(#7552): Fix notebook snapshot image annotations #7555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7555 +/- ##
==========================================
+ Coverage 56.04% 56.16% +0.11%
==========================================
Files 672 672
Lines 27108 27104 -4
Branches 2629 2630 +1
==========================================
+ Hits 15194 15224 +30
+ Misses 11591 11557 -34
Partials 323 323
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
reviewed
Mar 6, 2024
ozyx
commented
Mar 7, 2024
| @@ -516,6 +516,30 @@ test.describe('foo test suite', () => { | |||
| - Working with multiple pages | |||
| There are instances where multiple browser pages will needed to verify multi-page or multi-tab application behavior. Make sure to use the `@2p` annotation as well as name each page appropriately: i.e. `page1` and `page2` or `tab1` and `tab2` depending on the intended use case. Generally pages should be used unless testing `sharedWorker` code, specifically. | |||
|
|
|||
| - Working with file downloads and JSON data | |||
| Open MCT has the capability of exporting certain objects in the form of a JSON file handled by the chrome browser. The best example of this type of test can be found in the exportAsJson test. | |||
There was a problem hiding this comment.
This is great, although I'm worried that without something specific to our e2e testing framework we're just reproducing the Playwright docs here?
ozyx
commented
Mar 7, 2024
Comment on lines
+146
to
+157
| // Save as JPG | ||
| await Promise.all([ | ||
| page.waitForEvent('download'), // Waits for the download event | ||
| page.getByLabel('Export as JPG').click() // Triggers the download | ||
| ]); | ||
|
|
||
| // Save as PNG | ||
| await expect(page.getByLabel('Modal Overlay').getByRole('img')).toBeVisible(); | ||
| await Promise.all([ | ||
| page.waitForEvent('download'), // Waits for the download event | ||
| page.getByLabel('Export as PNG').click() // Triggers the download | ||
| ]); |
jvigliotta
reviewed
Mar 8, 2024
jvigliotta
requested changes
Mar 8, 2024
jvigliotta
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7552
Describe your changes:
Fixes imports for
painterroas it is exporting CJS, and this is now ESM.Needed to change:
to
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist