-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize plans properly #7597
Resize plans properly #7597
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7597 +/- ##
==========================================
- Coverage 56.46% 56.17% -0.30%
==========================================
Files 672 672
Lines 27112 27111 -1
Branches 2635 2635
==========================================
- Hits 15310 15229 -81
- Misses 11477 11557 +80
Partials 325 325
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with 1 nitpick that you could take or leave
I wonder if we can have a visual test that resizes a plan? that might catch a regression like this. |
Closes #7587
Describe your changes:
Ensure element isn't null for the resize observer, and that we're deeply watching the size.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist