Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For an existing View in a Preview, ensure we pull the same ActionCollection #7632

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Mar 21, 2024

Closes #7158

Describe your changes:

In Preview mode, we weren't pulling the same cached copy of the ActionsCollection, and thus weren't picking up any state changes from the View.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Mar 21, 2024 that may be closed by this pull request
7 tasks
@scottbell scottbell added this to the Target:4.0.0 milestone Mar 21, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 21, 2024
@scottbell scottbell marked this pull request as ready for review March 21, 2024 12:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.96%. Comparing base (493b31d) to head (e3fcd40).

❗ Current head e3fcd40 differs from pull request most recent head 1b4ff1b. Consider uploading reports for the commit 1b4ff1b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7632      +/-   ##
==========================================
- Coverage   56.32%   55.96%   -0.36%     
==========================================
  Files         672      672              
  Lines       27128    27119       -9     
  Branches     2635     2632       -3     
==========================================
- Hits        15279    15178     -101     
- Misses      11522    11612      +90     
- Partials      327      329       +2     
Flag Coverage Δ
e2e-full 23.57% <ø> (ø)
e2e-stable 59.51% <ø> (-0.87%) ⬇️
unit 49.09% <100.00%> (-0.03%) ⬇️
Files Coverage Δ
src/ui/preview/PreviewContainer.vue 27.02% <ø> (-1.37%) ⬇️
src/ui/preview/PreviewHeader.vue 45.45% <100.00%> (-5.98%) ⬇️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493b31d...1b4ff1b. Read the comment docs.

@scottbell scottbell modified the milestones: Target:4.0.0, Target:4.0.1 Mar 21, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 21, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a couple suggestions

src/ui/preview/PreviewHeader.vue Outdated Show resolved Hide resolved
src/ui/preview/PreviewHeader.vue Outdated Show resolved Hide resolved
@scottbell scottbell requested a review from ozyx March 26, 2024 10:09
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scottbell scottbell enabled auto-merge (squash) March 26, 2024 14:00
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 26, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 26, 2024
@scottbell scottbell merged commit 5391384 into master Mar 26, 2024
19 checks passed
@scottbell scottbell deleted the 7158-telemetry-table-menu-actions-not-available-in-preview-mode branch March 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry Table menu actions not available in Preview mode
4 participants