Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(visual): skip flaky visual test #7776

Merged
merged 1 commit into from
Jul 15, 2024
Merged

test(visual): skip flaky visual test #7776

merged 1 commit into from
Jul 15, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Jul 15, 2024

Closes #7775

Describe your changes:

Add a fixme to skip the flaky visual test. The test flakes due to content shifting after the initial DOM has loaded. This seems to be caused by loading Open MCT icons. You may have noticed blank icons in some of the snapshots, and I think this issue has the same cause. The icons are not being preloaded and thus load well after the initial DOM content has loaded. Will file a separate issue to fix this and link it here

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jul 15, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Jul 15, 2024
@ozyx ozyx requested a review from unlikelyzero July 15, 2024 16:41
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (0215a5b) to head (af94408).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7776      +/-   ##
==========================================
- Coverage   57.08%   56.66%   -0.42%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15513    15399     -114     
- Misses      11336    11447     +111     
- Partials      328      331       +3     
Flag Coverage Δ
e2e-full 23.57% <ø> (-18.53%) ⬇️
e2e-stable 60.63% <ø> (-0.03%) ⬇️
unit 49.27% <ø> (-0.16%) ⬇️

see 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0215a5b...af94408. Read the comment docs.

@ozyx ozyx merged commit 92e5cba into master Jul 15, 2024
29 checks passed
@ozyx ozyx deleted the mct7775 branch July 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Tests are failing on newly rendered time conductor tests
2 participants