chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7806 +/- ##
==========================================
- Coverage 57.32% 56.84% -0.49%
==========================================
Files 674 674
Lines 27283 27283
Branches 2669 2669
==========================================
- Hits 15639 15508 -131
- Misses 11305 11436 +131
Partials 339 339
see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
changed the title
unlikelyzero
requested changes
Aug 8, 2024
gotcha. will update |
unlikelyzero
approved these changes
Aug 9, 2024
ozyx
added a commit
that referenced
this pull request
Aug 13, 2024
… perf test (#7806) * test: fix broken locator in imagery perf test * Prevent this from happening * make rule explicit * test: maintain `locator()` pattern for contract tests * test(couchdb): try some new techniques to stabilize the test * Revert "test(couchdb): try some new techniques to stabilize the test" This reverts commit 9aa1ea9. * chore: revert to `networkidle` and disable eslint rule * test: add `@network` annotation for tests with real network requests --------- Co-authored-by: Hill, John (ARC-TI)[KBR Wyle Services, LLC] <john.c.hill@nasa.gov>
ozyx
added a commit
that referenced
this pull request
Aug 13, 2024
…n locator in imagery perf test (#7812) chore: re-enable perf/mem tests on PR + fix broken locator in imagery perf test (#7806) * test: fix broken locator in imagery perf test * Prevent this from happening * make rule explicit * test: maintain `locator()` pattern for contract tests * test(couchdb): try some new techniques to stabilize the test * Revert "test(couchdb): try some new techniques to stabilize the test" This reverts commit 9aa1ea9. * chore: revert to `networkidle` and disable eslint rule * test: add `@network` annotation for tests with real network requests --------- Co-authored-by: Hill, John (ARC-TI)[KBR Wyle Services, LLC] <john.c.hill@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7807
Closes #7808
Describe your changes:
Fixes a locator in the perf tests which was broken after the merge of #7581 (e2e refactor + linting)
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist