Merge pull request #330 from avan989/new_lgtm_warning

fix #328, lgtm warning
nasa · Jan 21, 2020 · 9379371 · 9379371
2 parents 64ad0f5 + 9b10459
commit 9379371
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/os/posix/os-posix.h b/src/os/posix/os-posix.h
@@ -21,6 +21,8 @@
 /****************************************************************************************
                                     COMMON INCLUDE FILES
  ***************************************************************************************/
+#ifndef _os_posix_h_
+#define _os_posix_h_
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -110,4 +112,4 @@ int32 OS_Posix_FileSysAPI_Impl_Init(void);
 int32 OS_Posix_InternalTaskCreate_Impl (pthread_t *pthr, uint32 priority, size_t stacksz, PthreadFuncPtr_t entry, void *entry_arg);
 
 
-
+#endif /* End of os-posix*/
diff --git a/src/os/shared/osapi-idmap.c b/src/os/shared/osapi-idmap.c
@@ -484,11 +484,11 @@ static int32 OS_ObjectIdFindNext(uint32 idtype, uint32 *array_index, OS_common_r
 {
    uint32 max_id;
    uint32 base_id;
-   uint32 local_id;
+   uint32 local_id = 0;
    uint32 idvalue;
    uint32 i;
    int32 return_code;
-   OS_common_record_t *obj;
+   OS_common_record_t *obj = NULL;
 
    base_id = OS_GetBaseForObjectType(idtype);
    max_id = OS_GetMaxForObjectType(idtype);

diff --git a/src/os/shared/osapi-sockets.c b/src/os/shared/osapi-sockets.c
@@ -211,7 +211,7 @@ int32 OS_SocketAccept(uint32 sock_id, uint32 *connsock_id, OS_SockAddr_t *Addr,
    OS_common_record_t *record;
    OS_common_record_t *connrecord;
    uint32 local_id;
-   uint32 conn_id;
+   uint32 conn_id = 0;
    int32 return_code;
 
    /* Check Parameters */

diff --git a/src/os/shared/osapi-time.c b/src/os/shared/osapi-time.c
@@ -389,7 +389,7 @@ int32 OS_TimerDelete(uint32 timer_id)
 {
     OS_timecb_internal_record_t *local;
     OS_common_record_t *record;
-    OS_common_record_t *timebase;
+    OS_common_record_t *timebase = NULL;
     int32             return_code;
     uint32            local_id;
     uint32            dedicated_timebase_id;