vxworks OS_SymTableIterator() name arg too long

[skliper]

The OS_SymTableIterator() name arg could be too long and could be strncpy/copied without a terminating null into SymbolRecord_t's char SymbolName[OS_MAX_SYM_LEN];. This unterminated null would then be written into the OS_sym_table_file_fd.

See osloader.c, ln 189.

Recommend: an explicit name length check:
{{{
if (strlen >= OS_MAX_SYM_LEN) {
return(FALSE);
}
}}}
before strncpy.

(Discovered as part of #45 coverage testing.)

[skliper]

Imported from trac issue 77. Created by abrown4 on 2015-07-15T11:52:38, last modified: 2015-12-01T14:31:57

[skliper]

Trac comment by abrown4 on 2015-07-20 16:47:18:

commit: [changeset:17a4c30] Trac #100, Fixed vxworks OS_SymTableIterator() name arg too long.

Also supplied unit test to illustrate the problem and check fix.

[skliper]

Trac comment by abrown4 on 2015-11-25 13:01:49:

Traceability: This change is reflected in #135 [changeset:093359f]. Recommend closing #100.